Differential D7958

[backport#16757] doc: CChainState return values
ClosedPublic
Actions

Authored by majcosta on Oct 16 2020, 16:20.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC3ee09fbcd837: [backport#16757] doc: CChainState return values

Summary

fa912a8ad5a94cd2bdc149400b1befb346621f03 doc: move-only ActivateBestChain doxygen comment to header (MarcoFalke)
fa99efd054c57cd6717391f9ae8ce32b06986ff8 doc: ActivateBestChainStep return value (MarcoFalke)

Pull request description:

It will always return true, unless a system error such as #15305 occurred

ACKs for top commit:

laanwj:
  ACK fa912a8ad5a94cd2bdc149400b1befb346621f03

Backport of Core PR16757

Test Plan

read the comments

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Oct 16 2020, 16:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 16 2020, 16:20

majcosta requested review of this revision.Oct 16 2020, 16:20

teamcity edited the summary of this revision. (Show Details)Oct 16 2020, 16:20

deadalnix accepted this revision.Oct 16 2020, 16:30

This revision is now accepted and ready to land.Oct 16 2020, 16:30

Harbormaster completed remote builds in B13458: Diff 24729.Oct 16 2020, 16:43

Closed by commit rABC3ee09fbcd837: [backport#16757] doc: CChainState return values (authored by Wladimir J. van der Laan <laanwj@protonmail.com>, committed by majcosta). · Explain WhyOct 16 2020, 17:05

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC3ee09fbcd837: [backport#16757] doc: CChainState return values.

Revision Contents
Changeset List

Path

Size

src/

validation.h

15 lines

validation.cpp

12 lines

Diff 24732

View Options

src/validation.h