Attempting to land-via-bot on a branch/commit with no revision results
in a not-useful error message. This patch ensures a comprehensible message is
provided instead.
Depends on D7959
Details
Details
- Reviewers
majcosta - Group Reviewers
Restricted Project - Commits
- rABC39fae5b8b23d: [land-bot] Give a reasonable error when a revision cannot be found
On clean master, author a commit and then cherry-pick this patch. The following
commands should give reasonable error messages:
arc land-via-bot --preview HEAD~ arc land-via-bot --hold HEAD~
On clean master:
git checkout <this-patch> arcanist/workflow/ArcanistLandBotWorkflow.php git commit -m "Test commit with no revision information"
The following commands should give reasonable error messages:
arc land-via-bot --preview arc land-via-bot --hold
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- lvb-missing-rev
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 13463 Build 26957: Build Diff lint-circular-dependencies · build-without-wallet · build-diff · build-clang-tidy · build-clang Build 26956: arc lint + arc unit