Page MenuHomePhabricator
Differential D7966

Merge #17564: rpc: Use mempool from node context instead of global
ClosedPublic
Actions

Authored by jasonbcox on Oct 16 2020, 21:52.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC73d648a23683: Merge #17564: rpc: Use mempool from node context instead of global
Summary

fa8e650b525e9493bdfa393c0c3e34cb22c78c08 rest: Use mempool from node context instead of global (MarcoFalke)
fa660d65d7cc401ad5bbfdc076a074de19a79329 node: Use mempool from node context instead of global (MarcoFalke)
facbaf092f1ab298943206603cff6e6e3d30d452 rpc: Use mempool from node context instead of global (MarcoFalke)

Pull request description:

Currently they are identical, but in the future we might want to turn
the mempool into a unique_ptr. Replacing the global with the mempool
pointer from the node context simplifies this step.

ACKs for top commit:

jnewbery:
  Code review ACK fa8e650b5
ryanofsky:
  Code review ACK fa8e650b525e9493bdfa393c0c3e34cb22c78c08, Only the discussed REST server changes since the last review.

Backport of Core PR17564

Depends on D7965

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Oct 16 2020, 21:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 16 2020, 21:52
jasonbcox requested review of this revision.Oct 16 2020, 21:52
teamcity edited the summary of this revision. (Show Details)Oct 16 2020, 21:53
jasonbcox planned changes to this revision.Oct 16 2020, 22:02
Harbormaster completed remote builds in B13467: Diff 24748.Oct 16 2020, 22:03
jasonbcox updated this revision to Diff 24749.Oct 16 2020, 22:13
  • Removed an unnecessary include
  • Patched changes onto estimateSmartFee since our code diverges from Core
Harbormaster completed remote builds in B13468: Diff 24749.Oct 16 2020, 22:21
deadalnix accepted this revision.Oct 16 2020, 23:27
deadalnix added a subscriber: deadalnix.

likestamp

This revision is now accepted and ready to land.Oct 16 2020, 23:27
Closed by commit rABC73d648a23683: Merge #17564: rpc: Use mempool from node context instead of global (authored by MarcoFalke <falke.marco@gmail.com>, committed by jasonbcox). · Explain WhyOct 16 2020, 23:39
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC73d648a23683: Merge #17564: rpc: Use mempool from node context instead of global.

Revision Contents
Changeset List

PathSize
src/
interfaces/
2 lines
12 lines
node/
4 lines
8 lines
5 lines
qt/
test/
1 line
43 lines
rpc/
50 lines
23 lines
16 lines
test/
10 lines

Diff 24751

View Options

src/interfaces/chain.cpp

Loading...
View Options

src/interfaces/node.cpp

Loading...
View Options

src/node/coin.h

Loading...
View Options

src/node/coin.cpp

Loading...
View Options

src/node/transaction.cpp

Loading...
View Options

src/qt/test/wallettests.cpp

Loading...
View Options

src/rest.cpp

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/rpc/mining.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/test/rpc_tests.cpp

Loading...