Page MenuHomePhabricator

Merge #17564: rpc: Use mempool from node context instead of global
ClosedPublic

Authored by jasonbcox on Fri, Oct 16, 21:52.

Details

Summary

fa8e650b525e9493bdfa393c0c3e34cb22c78c08 rest: Use mempool from node context instead of global (MarcoFalke)
fa660d65d7cc401ad5bbfdc076a074de19a79329 node: Use mempool from node context instead of global (MarcoFalke)
facbaf092f1ab298943206603cff6e6e3d30d452 rpc: Use mempool from node context instead of global (MarcoFalke)

Pull request description:

Currently they are identical, but in the future we might want to turn
the mempool into a unique_ptr. Replacing the global with the mempool
pointer from the node context simplifies this step.

ACKs for top commit:

jnewbery:
  Code review ACK fa8e650b5
ryanofsky:
  Code review ACK fa8e650b525e9493bdfa393c0c3e34cb22c78c08, Only the discussed REST server changes since the last review.

Backport of Core PR17564

Depends on D7965

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

  • Removed an unnecessary include
  • Patched changes onto estimateSmartFee since our code diverges from Core
This revision is now accepted and ready to land.Fri, Oct 16, 23:27