Page MenuHomePhabricator
Differential D7985

[backport#16224 1/5]gui: Add detailed text to BitcoinGUI::message
ClosedPublic
Actions

Authored by PiRK on Oct 19 2020, 15:26.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC4ca53cf0090b: [backport#16224 1/5]gui: Add detailed text to BitcoinGUI::message
Summary

Backport of Core PR16224 - part 1-5
Commit https://github.com/bitcoin/bitcoin/pull/16224/commits/23b9fa2e5ec0425980301d2eebad81e660a5ea39

Test Plan

The added code is not yet used in this commit.
Just make sure it still compiles.
ninja

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 19 2020, 15:26
Owners added a reviewer: Restricted Owners Package.Oct 19 2020, 15:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 19 2020, 15:26
PiRK requested review of this revision.Oct 19 2020, 15:26
teamcity edited the summary of this revision. (Show Details)Oct 19 2020, 15:27
Harbormaster completed remote builds in B13493: Diff 24787.Oct 19 2020, 15:38
deadalnix added a subscriber: deadalnix.Oct 19 2020, 16:19

Please make sure you have all the PR parts up for review so we can know where this is going when reviewing individual parts. This also helps ensure there won't be a PR half merged in flight forever.

PiRK added a child revision: D7986: [backport#16224 2/5] Make ThreadSafe{MessageBox|Question} bilingual.Oct 20 2020, 09:54
deadalnix accepted this revision.Oct 20 2020, 13:47
This revision is now accepted and ready to land.Oct 20 2020, 13:47
Closed by commit rABC4ca53cf0090b: [backport#16224 1/5]gui: Add detailed text to BitcoinGUI::message (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyOct 20 2020, 14:12
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC4ca53cf0090b: [backport#16224 1/5]gui: Add detailed text to BitcoinGUI::message.

Revision Contents
Changeset List

PathSize
src/
qt/
23 lines
4 lines

Diff 24826

View Options

src/qt/bitcoingui.h

Loading...
View Options

src/qt/bitcoingui.cpp

Loading...