Paths

Table of Contentst

[backport#16224 2/5] Make ThreadSafe{MessageBox|Question} bilingual
ClosedPublic
Actions

Authored by PiRK on Oct 19 2020, 15:32.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABC44c87af6b56f: [backport#16224 2/5] Make ThreadSafe{MessageBox|Question} bilingual

Summary

This PR:

makes GUI error messages bilingual: user's native language + untranslated (i.e. English)

insures that only untranslated messages are written to the debug log file and to stderr (that is not the case on master).

Backport of Core PR16224 - part 2 of 5
https://github.com/bitcoin/bitcoin/pull/16224/commits/917ca93553917251e0fd59717a347c63cdfd8a14

Depends on D7985

Test Plan

ninja && ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 19 2020, 15:32

Owners added a reviewer: Restricted Owners Package.Oct 19 2020, 15:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 19 2020, 15:32

PiRK requested review of this revision.Oct 19 2020, 15:32

teamcity edited the summary of this revision. (Show Details)Oct 19 2020, 15:32

Harbormaster completed remote builds in B13494: Diff 24788.Oct 19 2020, 15:42

PiRK added a child revision: D7997: [backport#16224 3/5] Make InitError bilingual.Oct 20 2020, 09:54

PiRK edited the summary of this revision. (Show Details)

PiRK added a parent revision: D7985: [backport#16224 1/5]gui: Add detailed text to BitcoinGUI::message.

deadalnix accepted this revision.Oct 20 2020, 13:55

This revision is now accepted and ready to land.Oct 20 2020, 13:55

Closed by commit rABC44c87af6b56f: [backport#16224 2/5] Make ThreadSafe{MessageBox|Question} bilingual (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyOct 20 2020, 14:15

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC44c87af6b56f: [backport#16224 2/5] Make ThreadSafe{MessageBox|Question} bilingual.

Revision Contents
Changeset List

Path

Size

src/

httprpc.cpp

3 lines

httpserver.cpp

12 lines

index/

base.cpp

6 lines

init.cpp

42 lines

interfaces/

9 lines

3 lines

40 lines

6 lines

18 lines

qt/

15 lines

7 lines

10 lines

12 lines

8 lines

Diff 24827

View Options

src/httprpc.cpp

View Options

src/httpserver.cpp

View Options

src/index/base.cpp

View Options

src/init.cpp

View Options

src/interfaces/node.h

View Options

src/net.h

View Options

src/net.cpp

View Options

src/noui.h

View Options

src/noui.cpp

View Options

src/qt/bitcoingui.cpp

View Options

src/timedata.cpp

View Options

src/ui_interface.h

View Options

src/ui_interface.cpp

View Options

[backport#16224 2/5] Make ThreadSafe{MessageBox|Question} bilingualClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 24827

src/httprpc.cpp

src/httpserver.cpp

src/index/base.cpp

src/init.cpp

src/interfaces/node.h

src/net.h

src/net.cpp

src/noui.h

src/noui.cpp

src/qt/bitcoingui.cpp

src/timedata.cpp

src/ui_interface.h

src/ui_interface.cpp

src/validation.cpp

[backport#16224 2/5] Make ThreadSafe{MessageBox|Question} bilingual
ClosedPublic
Actions

Revision Contents
Changeset List