Details

Reviewers

Commits

rSTAGING6ef18a84bd26: Add support to build leveldb using cmake
rABC6ef18a84bd26: Add support to build leveldb using cmake

Summary

As per title

Test Plan

cmake -GNinja ..
ninja

Ensure that lebeldb is built properly. Repeat for windows build.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

leveldbcmake

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1373
Build 1373: arc lint + arc unit

Event Timeline

deadalnix created this revision.Dec 12 2017, 15:41

Harbormaster completed remote builds in B1356: Diff 2100.Dec 12 2017, 15:41

Fix error marking variables as advanced

Harbormaster completed remote builds in B1358: Diff 2103.Dec 12 2017, 17:08

deadalnix retitled this revision from Add support to build eveldb using cmake to Add support to build leveldb using cmake.Dec 12 2017, 17:09

This complains about not being able to find endian.h

This revision now requires changes to proceed.Dec 13 2017, 00:00

The specific errors are multiples of this:

ccache /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++  -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -I../src/leveldb/. -I../src/leveldb/include -Isrc/leveldb/include -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk   -std=gnu++11 -MD -MT src/leveldb/CMakeFiles/db_test.dir/db/db_test.cc.o -MF src/leveldb/CMakeFiles/db_test.dir/db/db_test.cc.o.d -o src/leveldb/CMakeFiles/db_test.dir/db/db_test.cc.o -c ../src/leveldb/db/db_test.cc
In file included from ../src/leveldb/db/db_test.cc:7:
In file included from ../src/leveldb/./db/db_impl.h:10:
In file included from ../src/leveldb/./db/dbformat.h:14:
In file included from ../src/leveldb/./util/coding.h:17:
In file included from ../src/leveldb/./port/port.h:14:
../src/leveldb/./port/port_posix.h:38:12: fatal error: 'endian.h' file not found
  #include <endian.h>
           ^~~~~~~~~~

Use public includes for leveldb

Harbormaster completed remote builds in B1363: Diff 2110.Dec 13 2017, 14:27

Same problems still. I was going to try doing something similar to what you had done with the GMP includes. Can still do if you would like.

This revision now requires changes to proceed.Dec 13 2017, 18:49

schancel added a child revision: D804: Add support to compile the util library with cmake.Dec 13 2017, 22:47

Define the OS properly, this should fix the build for OSX.

Harbormaster completed remote builds in B1372: Diff 2123.Dec 14 2017, 23:56

Export the OS definition publicly

Harbormaster completed remote builds in B1373: Diff 2124.Dec 15 2017, 00:11

schancel accepted this revision.Dec 15 2017, 00:27

This revision is now accepted and ready to land.Dec 15 2017, 00:27

Closed by commit rABC6ef18a84bd26: Add support to build leveldb using cmake (authored by deadalnix). · Explain WhyDec 15 2017, 00:30