Page MenuHomePhabricator

[backport#16224 5/5] util: Cleanup translation.h
ClosedPublic

Authored by PiRK on Oct 20 2020, 10:07.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC626a4fc628fc: [backport#16224 5/5] util: Cleanup translation.h
Summary
Test Plan

ninja && ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a reviewer: Restricted Owners Package.Oct 20 2020, 10:08
PiRK requested review of this revision.Oct 20 2020, 10:08

Tail of the build log:

  -t abc-base-image-"${HASH}" debian:buster

(cat <<EOF
results() {
  set +e
  shopt -s dotglob nullglob
  mv /work/abc-ci-builds/"build-debug"/* /results
  chown -R ${ME} /work
  chown -R ${ME} /results
  chown -R ${ME} /root/.ccache
}
trap "results" EXIT
export TEAMCITY_VERSION="2019.2.4 (build 72059)"
export BASE_CACHE="/root/abc-depends/cache"
export SDK_ARCHIVE_DIR="/root/abc-depends/osx-sdk"
export SOURCES_PATH="/root/abc-depends/sources"
mkdir -p "/root/abc-depends/cache" "/root/abc-depends/osx-sdk" "/root/abc-depends/sources"
./contrib/teamcity/build-configurations.py "build-debug"
EOF
) > run-command.sh
chmod +x run-command.sh

~/infra/docker/docker-run.sh \
  -a "-v /home/teamcity/.ccache:/root/.ccache -v /home/teamcity/.abc-depends:/root/abc-depends -v "${RESULTS_DIR}":/results" \
  -c run-command.sh /work/run-command.sh abc-base-image-"${HASH}" ./run-command.sh

[10:08:43] :	 [Step 1/1] Starting: /home/teamcity/buildAgent/temp/agentTmp/custom_script4005827980515856032
[10:08:43] :	 [Step 1/1] in directory: /home/teamcity/buildAgent/work/jailed-build
[10:08:43] :	 [Step 1/1] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[10:08:43] :	 [Step 1/1] ~/buildAgent/work/jailed-build
[10:08:43] :	 [Step 1/1] Building base image for: 3156ccfeb...
[10:08:43] :	 [Step 1/1] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[10:08:45] :	 [Step 1/1] ~/buildAgent/work/jailed-build
[10:08:45] :	 [Step 1/1] Tag name: abc-base-image-3156ccfeb
[10:09:06]W:	 [Step 1/1] Traceback (most recent call last):
[10:09:06]W:	 [Step 1/1]   File "./contrib/teamcity/build-configurations.py", line 570, in <module>
[10:09:06]W:	 [Step 1/1]     main()
[10:09:06]W:	 [Step 1/1]   File "./contrib/teamcity/build-configurations.py", line 559, in main
[10:09:06]W:	 [Step 1/1]     script_dir, config_path, args.build)
[10:09:06]W:	 [Step 1/1]   File "./contrib/teamcity/build-configurations.py", line 59, in __init__
[10:09:06]W:	 [Step 1/1]     self.load(build_name)
[10:09:06]W:	 [Step 1/1]   File "./contrib/teamcity/build-configurations.py", line 82, in load
[10:09:06]W:	 [Step 1/1]     self.name, list(config.keys())
[10:09:06]W:	 [Step 1/1] AssertionError: build-debug is not a valid build identifier. Valid identifiers are ['templates', 'builds']
[10:09:06]W:	 [Step 1/1] mv: missing destination file operand after '/results'
[10:09:06]W:	 [Step 1/1] Try 'mv --help' for more information.
[10:09:09]W:	 [Step 1/1] Process exited with code 1
[10:09:09]E:	 [Step 1/1] Process exited with code 1 (Step: Command Line)
[10:09:09]E:	 [Step 1/1] Step Command Line failed
[10:09:10]E: Ant JUnit report watcher
[10:09:10]E:	 [Ant JUnit report watcher] No reports found for paths:
[10:09:10]E:	 [Ant JUnit report watcher] +:results/test_bitcoin.xml
[10:09:10]E:	 [Ant JUnit report watcher] +:results/**/junit_results*.xml
[10:09:10] : Publishing internal artifacts (1s)
[10:09:11] :	 [Publishing internal artifacts] Publishing 1 file using [ArtifactsCachePublisher]
[10:09:11] :	 [Publishing internal artifacts] Publishing 1 file using [WebPublisher]
[10:09:10]W: Publishing artifacts (2s)
[10:09:10] :	 [Publishing artifacts] Collecting files to publish: [+:results/**/junit_results*.xml]
[10:09:10]W:	 [Publishing artifacts] Artifacts path 'results/**/junit_results*.xml' not found
[10:09:13] : Build finished
deadalnix requested changes to this revision.Oct 20 2020, 14:03
deadalnix added a subscriber: deadalnix.

Please point to the specific commit. You might also want to rebase these diffs where the CI failed to make sure.

This revision now requires changes to proceed.Oct 20 2020, 14:03
This revision is now accepted and ready to land.Oct 20 2020, 18:00