Page MenuHomePhabricator

[backport#16822 1/3] gui: rename encrypt(), blank(), disablePrivateKeys()
ClosedPublic

Authored by PiRK on Oct 20 2020, 15:29.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC075c2361622f: [backport#16822 1/3] gui: rename encrypt(), blank(), disablePrivateKeys()
Summary

to be consistent in naming.

Backport of Core PR16822 - part 1 of 3
Commit https://github.com/bitcoin/bitcoin/pull/16822/commits/43aa9b0d790840e30c1cd128e67946ffcbfeb721

Note: on our side the spelling of the method name askPassphrase was already good
when it was first backported (see D7105)

Test Plan

Method renaming without change in the logic.
Just compile to make sure it didn't break anything.
ninja

Event Timeline

Owners added a reviewer: Restricted Owners Package.Oct 20 2020, 15:29
PiRK requested review of this revision.Oct 20 2020, 15:29
PiRK retitled this revision from [backport#16822]gui: rename encrypt(), blank(), disablePrivateKeys() to [backport#16822 1/3] gui: rename encrypt(), blank(), disablePrivateKeys().Oct 20 2020, 15:44
jasonbcox requested changes to this revision.Oct 20 2020, 16:04
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/qt/createwalletdialog.cpp
31

Missed encrypt -> isEncryptWalletChecked

This revision now requires changes to proceed.Oct 20 2020, 16:04

fix missed encrypt -> isEncryptWalletChecked

This revision is now accepted and ready to land.Oct 20 2020, 16:16

Tail of the build log:

[357/418] Running utility command for check-bitcoin-sighashtype_tests
[358/418] Running utility command for check-bitcoin-sync_tests
[359/418] Running utility command for check-bitcoin-torcontrol_tests
[360/418] bitcoin: testing settings_tests
[361/418] bitcoin: testing timedata_tests
[362/418] Running utility command for check-bitcoin-settings_tests
[363/418] Running utility command for check-bitcoin-timedata_tests
[364/418] bitcoin: testing streams_tests
[365/418] Running utility command for check-bitcoin-streams_tests
[366/418] bitcoin: testing uint256_tests
[367/418] bitcoin: testing undo_tests
[368/418] Running utility command for check-bitcoin-uint256_tests
[369/418] Running utility command for check-bitcoin-undo_tests
[370/418] bitcoin: testing util_threadnames_tests
[371/418] bitcoin: testing walletdb_tests
[372/418] Running utility command for check-bitcoin-util_threadnames_tests
[373/418] Running utility command for check-bitcoin-walletdb_tests
[374/418] bitcoin: testing compilerbug_tests
[375/418] Running utility command for check-bitcoin-compilerbug_tests
[376/418] bitcoin: testing checkpoints_tests
[377/418] bitcoin: testing serialize_tests
[378/418] Running utility command for check-bitcoin-checkpoints_tests
[379/418] bitcoin: testing txvalidationcache_tests
[380/418] Running utility command for check-bitcoin-serialize_tests
[381/418] bitcoin: testing validationinterface_tests
[382/418] Running utility command for check-bitcoin-txvalidationcache_tests
[383/418] Running utility command for check-bitcoin-validationinterface_tests
[384/418] bitcoin: testing radix_tests
[385/418] bitcoin: testing script_standard_tests
[386/418] bitcoin: testing cashaddr_tests
[387/418] Running utility command for check-bitcoin-radix_tests
[388/418] Running utility command for check-bitcoin-script_standard_tests
[389/418] Running utility command for check-bitcoin-cashaddr_tests
[390/418] bitcoin: testing crypto_tests
[391/418] bitcoin: testing blockcheck_tests
[392/418] Running utility command for check-bitcoin-crypto_tests
[393/418] bitcoin: testing ref_tests
[394/418] Running utility command for check-bitcoin-blockcheck_tests
[395/418] Running utility command for check-bitcoin-ref_tests
[396/418] bitcoin: testing bswap_tests
[397/418] Running utility command for check-bitcoin-bswap_tests
[398/418] bitcoin: testing script_tests
[399/418] Running utility command for check-bitcoin-script_tests
[400/418] bitcoin: testing validation_tests
[401/418] bitcoin: testing cuckoocache_tests
[402/418] bitcoin: testing validation_block_tests
[403/418] Running utility command for check-bitcoin-validation_tests
[404/418] Running utility command for check-bitcoin-cuckoocache_tests
[405/418] Running utility command for check-bitcoin-validation_block_tests
[406/418] bitcoin: testing skiplist_tests
[407/418] Running utility command for check-bitcoin-skiplist_tests
[408/418] bitcoin: testing monolith_opcodes_tests
[409/418] Running utility command for check-bitcoin-monolith_opcodes_tests
[410/418] bitcoin: testing util_tests
[411/418] Running utility command for check-bitcoin-util_tests
[412/418] bitcoin: testing transaction_tests
[413/418] Running utility command for check-bitcoin-transaction_tests
[414/418] bitcoin: testing coins_tests
[415/418] Running utility command for check-bitcoin-coins_tests
Build build-clang timed out after 1200.0s
This revision was landed with ongoing or failed builds.Oct 20 2020, 18:55
This revision was automatically updated to reflect the committed changes.