askpassphrasedialog
ClosedPublic
Actions

Authored by PiRK on Oct 20 2020, 15:36.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABC334559d6fb45: [backport#16822 2/3] gui: fix passphrase labels/tooltip in…

Summary

UI improvements:

update remaining GUI wallet labels and tooltips from passwords to passphrases
improve grammar of labels in askpassphrase dialog and WalletController::closeWallet

Backport of Core PR16822 - part 2 of 3
Commit https://github.com/bitcoin/bitcoin/pull/16822/commits/539d9403af956c76ae0149a58c07c71a6b58ac69

Depends on D8006

Test Plan

ninja

Run src/qt/bitcoin-qt, create a new wallet with encryption and check the text in the dialogs.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 20 2020, 15:36

Owners added a reviewer: Restricted Owners Package.Oct 20 2020, 15:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 20 2020, 15:36

PiRK requested review of this revision.Oct 20 2020, 15:36

teamcity edited the summary of this revision. (Show Details)Oct 20 2020, 15:36

PiRK retitled this revision from gui: fix passphrase labels/tooltip in createwalletdialog/askpassphrasedialog to [backport#16822 2/3] gui: fix passphrase labels/tooltip in createwalletdialog/askpassphrasedialog.Oct 20 2020, 15:37

PiRK added a child revision: D8008: [backport#16822 3/3] gui: fix autofocus in CreateWalletActivity::askPassphrase().Oct 20 2020, 15:39

jasonbcox accepted this revision.Oct 20 2020, 16:05

This revision is now accepted and ready to land.Oct 20 2020, 16:05

Harbormaster completed remote builds in B13529: Diff 24840.Oct 20 2020, 16:10

Closed by commit rABC334559d6fb45: [backport#16822 2/3] gui: fix passphrase labels/tooltip in… (authored by Jon Atack <jon@atack.com>, committed by PiRK). · Explain WhyOct 20 2020, 19:03

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC334559d6fb45: [backport#16822 2/3] gui: fix passphrase labels/tooltip in….