[build-bot] Fix skipping comments in ignore list
ClosedPublic
Actions

Authored by jasonbcox on Oct 21 2020, 18:26.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCa99c8c9710a8: [build-bot] Fix skipping comments in ignore list

Summary

Attempting to check the first character of a byte sequence does not make sense.
This patch fixes that check in order to correctly skip comments in the ignore list and
provides a false-positive test to ensure we do not regress.

Test Plan

pytest

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Oct 21 2020, 18:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 21 2020, 18:26

jasonbcox requested review of this revision.Oct 21 2020, 18:26

Harbormaster completed remote builds in B13568: Diff 24906.Oct 21 2020, 19:11

Added strip() to detect indented comments as well

Fabien accepted this revision.Oct 21 2020, 19:24

This revision is now accepted and ready to land.Oct 21 2020, 19:24

This revision was landed with ongoing or failed builds.Oct 21 2020, 21:21

Closed by commit rABCa99c8c9710a8: [build-bot] Fix skipping comments in ignore list (authored by jasonbcox). · Explain Why

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABCa99c8c9710a8: [build-bot] Fix skipping comments in ignore list.

Revision Contents
Changeset List

Path

Size

contrib/

buildbot/

server.py

2 lines

test/

test_endpoint_status.py

26 lines

Diff 24916

View Options

contrib/buildbot/server.py