Page MenuHomePhabricator

[build-bot] Fix skipping comments in ignore list
ClosedPublic

Authored by jasonbcox on Oct 21 2020, 18:26.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCa99c8c9710a8: [build-bot] Fix skipping comments in ignore list
Summary

Attempting to check the first character of a byte sequence does not make sense.
This patch fixes that check in order to correctly skip comments in the ignore list and
provides a false-positive test to ensure we do not regress.

Test Plan

pytest

Diff Detail

Event Timeline

Added strip() to detect indented comments as well

This revision is now accepted and ready to land.Oct 21 2020, 19:24
This revision was landed with ongoing or failed builds.Oct 21 2020, 21:21
This revision was automatically updated to reflect the committed changes.