Page MenuHomePhabricator

Merge #13928: qa: blocktools enforce named args for amount
ClosedPublic

Authored by jasonbcox on Oct 21 2020, 21:35.

Details

Summary

cf9ed307e6 qa: blocktools enforce named args for amount (MarcoFalke)

Pull request description:

Since  #13669 changed some signatures, I think it might be worthwhile to enforce named args for primitive types such as amounts.

Backport of Core PR13928

Note that our feature_csv_activation.py differs from Core, so I applied the patch in best spirit with the original PR.

Test Plan
ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Tail of the build log:

[359/411] bitcoin: testing settings_tests
[360/411] Running utility command for check-bitcoin-torcontrol_tests
[361/411] Running utility command for check-bitcoin-timedata_tests
[362/411] Running utility command for check-bitcoin-settings_tests
[363/411] bitcoin: testing uint256_tests
[364/411] Running utility command for check-bitcoin-uint256_tests
[365/411] bitcoin: testing undo_tests
[366/411] Running utility command for check-bitcoin-undo_tests
[367/411] bitcoin: testing compilerbug_tests
[368/411] bitcoin: testing walletdb_tests
[369/411] Running utility command for check-bitcoin-compilerbug_tests
[370/411] Running utility command for check-bitcoin-walletdb_tests
[371/411] bitcoin: testing checkpoints_tests
[372/411] bitcoin: testing validationinterface_tests
[373/411] Running utility command for check-bitcoin-checkpoints_tests
[374/411] Running utility command for check-bitcoin-validationinterface_tests
[375/411] bitcoin: testing serialize_tests
[376/411] Running utility command for check-bitcoin-serialize_tests
[377/411] bitcoin: testing txvalidationcache_tests
[378/411] Running utility command for check-bitcoin-txvalidationcache_tests
[379/411] bitcoin: testing script_standard_tests
[380/411] bitcoin: testing radix_tests
[381/411] Running utility command for check-bitcoin-script_standard_tests
[382/411] Running utility command for check-bitcoin-radix_tests
[383/411] bitcoin: testing cuckoocache_tests
[384/411] Running utility command for check-bitcoin-cuckoocache_tests
[385/411] bitcoin: testing ref_tests
[386/411] Running utility command for check-bitcoin-ref_tests
[387/411] bitcoin: testing crypto_tests
[388/411] bitcoin: testing bswap_tests
[389/411] Running utility command for check-bitcoin-crypto_tests
[390/411] Running utility command for check-bitcoin-bswap_tests
[391/411] bitcoin: testing blockcheck_tests
[392/411] bitcoin: testing validation_block_tests
[393/411] Running utility command for check-bitcoin-blockcheck_tests
[394/411] Running utility command for check-bitcoin-validation_block_tests
[395/411] bitcoin: testing validation_tests
[396/411] bitcoin: testing script_tests
[397/411] Running utility command for check-bitcoin-validation_tests
[398/411] Running utility command for check-bitcoin-script_tests
[399/411] bitcoin: testing monolith_opcodes_tests
[400/411] bitcoin: testing skiplist_tests
[401/411] Running utility command for check-bitcoin-monolith_opcodes_tests
[402/411] bitcoin: testing coinselector_tests
FAILED: src/test/CMakeFiles/check-bitcoin-coinselector_tests 
cd /work/abc-ci-builds/build-clang-tidy/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang-tidy/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang-tidy/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-clang-tidy/test/log/bitcoin-coinselector_tests.log /work/abc-ci-builds/build-clang-tidy/src/test/test_bitcoin --run_test=coinselector_tests --logger=HRF,test_suite:JUNIT,message,bitcoin-coinselector_tests.xml --catch_system_errors=no
Running 4 test cases...
Entering test module "Bitcoin ABC unit tests"
../../src/wallet/test/coinselector_tests.cpp(22): Entering test suite "coinselector_tests"
../../src/wallet/test/coinselector_tests.cpp(149): Entering test case "bnb_search_test"
Segmentation fault (core dumped)
[403/411] Running utility command for check-bitcoin-skiplist_tests
[404/411] bitcoin: testing util_tests
[405/411] Running utility command for check-bitcoin-util_tests
[406/411] bitcoin: testing transaction_tests
[407/411] Running utility command for check-bitcoin-transaction_tests
[408/411] bitcoin: testing coins_tests
[409/411] Running utility command for check-bitcoin-coins_tests
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
deadalnix requested changes to this revision.Oct 21 2020, 22:11
deadalnix added a subscriber: deadalnix.

CI is not happy.

This revision now requires changes to proceed.Oct 21 2020, 22:11

Re-ran CI. It looks like the new logging fix is working, so hopefully we can nail the flakiness in that test soon.

This revision is now accepted and ready to land.Oct 22 2020, 21:21