Differential D8036

[SECP256K1] Add fallback LE/BE for architectures with known endianness + SHA256 selftest
ClosedPublic
Actions

Authored by Fabien on Oct 22 2020, 08:10.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCcb45b773f981: [SECP256K1] Add fallback LE/BE for architectures with known endianness + SHA256…

Summary

These are all the architecture macros I could find with known
endianness. Use those as a fallback when BYTE_ORDER isn't available.

See #787 (comment)

It also adds a SHA256 selftest, so that improperly overriding the
endianness detection will be detected at runtime.

Backport of secp256k1 PR799.

Test Plan

ninja check-secp256k1

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 22 2020, 08:10

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 22 2020, 08:10

Fabien requested review of this revision.Oct 22 2020, 08:10

teamcity edited the summary of this revision. (Show Details)Oct 22 2020, 08:10

Harbormaster completed remote builds in B13577: Diff 24925.Oct 22 2020, 08:24

Fabien added a child revision: D8037: [SECP256K1] Switch to our own memcmp function.Oct 22 2020, 08:37

Fabien retitled this revision from Add fallback LE/BE for architectures with known endianness + SHA256 selftest to [SECP256K1] Add fallback LE/BE for architectures with known endianness + SHA256 selftest.Oct 22 2020, 09:30

deadalnix accepted this revision.Oct 22 2020, 11:52

This revision is now accepted and ready to land.Oct 22 2020, 11:52

Closed by commit rABCcb45b773f981: [SECP256K1] Add fallback LE/BE for architectures with known endianness + SHA256… (authored by Pieter Wuille <pieter@wuille.net>, committed by Fabien). · Explain WhyOct 22 2020, 19:49

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCcb45b773f981: [SECP256K1] Add fallback LE/BE for architectures with known endianness + SHA256….