Page MenuHomePhabricator
Differential D8037

[SECP256K1] Switch to our own memcmp function
ClosedPublic
Actions

Authored by Fabien on Oct 22 2020, 08:32.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCfea82d5ce4ee: [SECP256K1] Switch to our own memcmp function
Summary
Fixes #823.

Backport 1/11 of secp256k1 PR830:
https://github.com/bitcoin-core/secp256k1/pull/830/commits/6173839c90553385171d560be8a17cbe167e3bef

Note: the first memcmp() in recovery/tests_impl.h was removed in
D2193.

Depends on D8036.

Test Plan
ninja check-secp256k1

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 22 2020, 08:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 22 2020, 08:32
Fabien requested review of this revision.Oct 22 2020, 08:32
Fabien edited the summary of this revision. (Show Details)Oct 22 2020, 08:37
Fabien added a parent revision: D8036: [SECP256K1] Add fallback LE/BE for architectures with known endianness + SHA256 selftest.
Harbormaster completed remote builds in B13578: Diff 24926.Oct 22 2020, 08:40
Fabien edited the summary of this revision. (Show Details)Oct 22 2020, 08:44
Fabien retitled this revision from Switch to our own memcmp function to [SECP256K1] Switch to our own memcmp function.Oct 22 2020, 09:30
deadalnix accepted this revision.Oct 22 2020, 11:52
This revision is now accepted and ready to land.Oct 22 2020, 11:52
Closed by commit rABCfea82d5ce4ee: [SECP256K1] Switch to our own memcmp function (authored by Tim Ruffing <crypto@timruffing.de>, committed by Fabien). · Explain WhyOct 22 2020, 19:52
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCfea82d5ce4ee: [SECP256K1] Switch to our own memcmp function.

Revision Contents
Changeset List

PathSize
src/
secp256k1/
src/
modules/
ecdh/
4 lines
extrakeys/
2 lines
6 lines
62 lines
recovery/
4 lines
schnorrsig/
2 lines
4 lines
14 lines
10 lines
2 lines
234 lines
18 lines

Diff 24961

View Options

src/secp256k1/src/modules/ecdh/tests_impl.h

Loading...
View Options

src/secp256k1/src/modules/extrakeys/main_impl.h

Loading...
View Options

src/secp256k1/src/modules/extrakeys/tests_exhaustive_impl.h

Loading...
View Options

src/secp256k1/src/modules/extrakeys/tests_impl.h

Loading...
View Options

src/secp256k1/src/modules/recovery/tests_impl.h

Loading...
View Options

src/secp256k1/src/modules/schnorrsig/main_impl.h

Loading...
View Options

src/secp256k1/src/modules/schnorrsig/tests_exhaustive_impl.h

Loading...
View Options

src/secp256k1/src/modules/schnorrsig/tests_impl.h

Loading...
View Options

src/secp256k1/src/scratch_impl.h

Loading...
View Options

src/secp256k1/src/selftest.h

Loading...
View Options

src/secp256k1/src/tests.c

Loading...
View Options

src/secp256k1/src/util.h

Loading...