Differential D8046

[SECP256K1] Reorder comments/function around scalar_split_lambda
ClosedPublic
Actions

Authored by Fabien on Oct 22 2020, 09:14.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCeeb6583ff924: [SECP256K1] Reorder comments/function around scalar_split_lambda

Summary

Partial backport 10/11 of secp256k1 PR830:
https://github.com/bitcoin-core/secp256k1/pull/830/commits/63c6b71616816b19bec9cb3ab6b45ae5afd955f0

Depends on D8045.

Test Plan

ninja check-secp256k1

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR830_part10

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13587
Build 27205: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 27204: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 22 2020, 09:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 22 2020, 09:14

Fabien requested review of this revision.Oct 22 2020, 09:14

teamcity edited the summary of this revision. (Show Details)Oct 22 2020, 09:14

Fabien added a child revision: D8047: [SECP256K1] Consistency improvements to the comments.Oct 22 2020, 09:16

Fabien retitled this revision from Reorder comments/function around scalar_split_lambda to [SECP256K1] Reorder comments/function around scalar_split_lambda.Oct 22 2020, 09:32

Harbormaster completed remote builds in B13587: Diff 24935.Oct 22 2020, 09:46

deadalnix accepted this revision.Oct 22 2020, 11:03

This revision is now accepted and ready to land.Oct 22 2020, 11:03

Closed by commit rABCeeb6583ff924: [SECP256K1] Reorder comments/function around scalar_split_lambda (authored by Pieter Wuille <pieter@wuille.net>, committed by Fabien). · Explain WhyOct 22 2020, 20:02

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCeeb6583ff924: [SECP256K1] Reorder comments/function around scalar_split_lambda.