Page MenuHomePhabricator
Differential D8048

[backport#16521 1/2] wallet/rpc: Use the default maxfeerate value as BTC/kB
AbandonedPublic
Actions

Authored by PiRK on Oct 22 2020, 09:28.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

From issue 16382

When the "maxfeerate" option is not passed, the default fee rate is interpreted as an absolute amount. However, when it is passed, it is interpreted as a fee rate.

This makes the interpretation of the default value consistent with a provided value.

This is a backport of Core PR16521 - part 1 of 2
Commit: https://github.com/bitcoin/bitcoin/pull/16521/commits/261843e4bef96ab296a9775819a99bfa60cad743

Test Plan

ninja && ninja check && test/functional/test_runner.py mempool_accept.py wallet_basic.py

Diff Detail

Event Timeline

PiRK created this revision.Oct 22 2020, 09:28
Owners added a reviewer: Restricted Owners Package.Oct 22 2020, 09:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 22 2020, 09:28
PiRK requested review of this revision.Oct 22 2020, 09:28
teamcity edited the summary of this revision. (Show Details)Oct 22 2020, 09:29
Fabien requested changes to this revision.Oct 22 2020, 09:33
Fabien added a subscriber: Fabien.

https://reviews.bitcoinabc.org/D8027

This revision now requires changes to proceed.Oct 22 2020, 09:33
PiRK abandoned this revision.Oct 22 2020, 09:50

Already backported. I will abandon also PR16078 which i only backported to make this one easier.

Harbormaster completed remote builds in B13589: Diff 24937.Oct 22 2020, 09:55
• baby636 added a subscriber: • baby636.Jun 7 2021, 09:41

Revision Contents
Changeset List

PathSize
src/
rpc/
36 lines
test/
functional/
1 line
2 lines

Diff 24937

View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

test/functional/mempool_accept.py

Loading...
View Options

test/functional/wallet_basic.py

Loading...