Make SignatureExtractorChecker private to its own file
ClosedPublic
Actions

Authored by PiRK on Oct 23 2020, 15:56.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABC1fd789f3dea0: Make SignatureExtractorChecker private to its own file

Summary

It's only used here in sign.cpp in DataFromTransaction(), so this enhances encapsulation.

This is a backport of Core PR13266

Test Plan

ninja && ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

backport-pr13266

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13639
Build 27307: Build Diff	build-without-wallet · lint-circular-dependencies · build-clang · build-diff · build-clang-tidy · build-debug
Build 27306: arc lint + arc unit

Event Timeline

PiRK created this revision.Oct 23 2020, 15:56

Owners added a reviewer: Restricted Owners Package.Oct 23 2020, 15:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 23 2020, 15:56

PiRK requested review of this revision.Oct 23 2020, 15:56

teamcity edited the summary of this revision. (Show Details)Oct 23 2020, 15:56

Harbormaster completed remote builds in B13639: Diff 25031.Oct 23 2020, 16:13

deadalnix accepted this revision.Oct 23 2020, 17:47

This revision is now accepted and ready to land.Oct 23 2020, 17:47

Closed by commit rABC1fd789f3dea0: Make SignatureExtractorChecker private to its own file (authored by Ben Woosley <ben.woosley@gmail.com>, committed by PiRK). · Explain WhyOct 24 2020, 13:17

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC1fd789f3dea0: Make SignatureExtractorChecker private to its own file.

Revision Contents
Changeset List

Path

Size

src/

script/

sign.cpp

23 lines

Diff 25031

View Options

Make SignatureExtractorChecker private to its own fileClosedPublicActions