[backport#11140] Trivial: Improve #endif comments
ClosedPublic
Actions

Authored by majcosta on Oct 29 2020, 05:03.

Details

Reviewers

PiRK
Fabien

Group Reviewers

Restricted Project

Commits

rABC6b08ed7779e1: [backport#11140] Trivial: Improve #endif comments

Summary

ac1cf8d Trivial: Improve #endif comments (danra)

Pull request description:

Improve the #endif comments for the '#if HAVE_DECL_BSWAP_XX == 0' preprocessor conditions, so each shows the full condition which it closes.

Backport of Core PR11140

Test Plan

ninja

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr11140

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13735
Build 27489: Build Diff	build-without-wallet · build-debug · build-clang-tidy · lint-circular-dependencies · build-clang · build-diff
Build 27488: arc lint + arc unit

Event Timeline

majcosta created this revision.Oct 29 2020, 05:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 29 2020, 05:03

majcosta requested review of this revision.Oct 29 2020, 05:03

teamcity edited the summary of this revision. (Show Details)Oct 29 2020, 05:03

Harbormaster completed remote builds in B13735: Diff 25214.Oct 29 2020, 05:11

PiRK accepted this revision.Oct 29 2020, 08:06

This revision is now accepted and ready to land.Oct 29 2020, 08:06

Fabien accepted this revision.Oct 29 2020, 08:08

Closed by commit rABC6b08ed7779e1: [backport#11140] Trivial: Improve #endif comments (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by majcosta). · Explain WhyOct 29 2020, 15:39

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC6b08ed7779e1: [backport#11140] Trivial: Improve #endif comments.

Revision Contents
Changeset List

Path

Size

src/

compat/

byteswap.h

6 lines

Diff 25214

View Options

[backport#11140] Trivial: Improve #endif commentsClosedPublicActions