Page MenuHomePhabricator

qt: Remove "Pay only required fee" checkbox

Authored by PiRK on Oct 29 2020, 14:32.


Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
rABC0c866043338f: qt: Remove "Pay only required fee" checkbox

The custom fee input box now has a minimum value equal to the minimum
required fee. Before a value below the minimum fee could be entered
which was confusing since the minimum fee would still be paid even
though a lower amount was entered.

Backport of Core PR14608 [2/2]

Depends on D8176

Test Plan

ninja && src/qt/bitcoin-qt -regtest

On the Spend page, custom fee section, verify that the "Pay only required fee" checkbox is no longer there and is replaced by a simple label.

Diff Detail

Event Timeline

Owners added a reviewer: Restricted Owners Package.Oct 29 2020, 14:32
PiRK requested review of this revision.Oct 29 2020, 14:32

Failed tests logs:

====== Bitcoin ABC functional tests: ======

------- Stdout: -------
2020-10-29T14:42:34.970000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201029_144200/p2p_timeouts_313
2020-10-29T14:42:40.283000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/", line 209, in main
  File "/work/test/functional/", line 89, in run_test
    assert not no_verack_node.is_connected
2020-10-29T14:42:42.271000Z TestFramework (INFO): Stopping nodes
2020-10-29T14:42:45.929000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201029_144200/p2p_timeouts_313
2020-10-29T14:42:45.930000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201029_144200/p2p_timeouts_313/test_framework.log
2020-10-29T14:42:45.930000Z TestFramework (ERROR): Hint: Call /work/test/functional/ '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201029_144200/p2p_timeouts_313' to consolidate all logs

Each failure log is accessible here:
Bitcoin ABC functional tests:

This revision is now accepted and ready to land.Oct 29 2020, 15:48