qt: Remove "Pay only required fee" checkbox
ClosedPublic
Actions

Authored by PiRK on Oct 29 2020, 14:32.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABC0c866043338f: qt: Remove "Pay only required fee" checkbox

Summary

The custom fee input box now has a minimum value equal to the minimum
required fee. Before a value below the minimum fee could be entered
which was confusing since the minimum fee would still be paid even
though a lower amount was entered.

Backport of Core PR14608 [2/2]
Commit https://github.com/bitcoin/bitcoin/pull/14608/commits/a16f44c040642432e234ad7317b00fe829c2d9e7

Depends on D8176

Test Plan

ninja && src/qt/bitcoin-qt -regtest

On the Spend page, custom fee section, verify that the "Pay only required fee" checkbox is no longer there and is replaced by a simple label.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

backport-pr14608

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13757
Build 27533: Build Diff	lint-circular-dependencies · build-without-wallet · build-clang · build-debug · build-diff · build-clang-tidy
Build 27532: arc lint + arc unit

Event Timeline

PiRK created this revision.Oct 29 2020, 14:32

Owners added a reviewer: Restricted Owners Package.Oct 29 2020, 14:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 29 2020, 14:32

PiRK requested review of this revision.Oct 29 2020, 14:32

teamcity edited the summary of this revision. (Show Details)Oct 29 2020, 14:32

PiRK edited the summary of this revision. (Show Details)Oct 29 2020, 14:32

PiRK added a parent revision: D8176: qt: Improve BitcoinAmountField class.

Harbormaster completed remote builds in B13745: Diff 25226.Oct 29 2020, 14:44

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: p2p_timeouts.py ======

------- Stdout: -------
2020-10-29T14:42:34.970000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201029_144200/p2p_timeouts_313
2020-10-29T14:42:40.283000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 209, in main
    self.run_test()
  File "/work/test/functional/p2p_timeouts.py", line 89, in run_test
    assert not no_verack_node.is_connected
AssertionError
2020-10-29T14:42:42.271000Z TestFramework (INFO): Stopping nodes
2020-10-29T14:42:45.929000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201029_144200/p2p_timeouts_313
2020-10-29T14:42:45.930000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201029_144200/p2p_timeouts_313/test_framework.log
2020-10-29T14:42:45.930000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201029_144200/p2p_timeouts_313' to consolidate all logs

Each failure log is accessible here:
Bitcoin ABC functional tests: p2p_timeouts.py

Fabien accepted this revision.Oct 29 2020, 15:48

This revision is now accepted and ready to land.Oct 29 2020, 15:48

rebase

Harbormaster completed remote builds in B13757: Diff 25251.Oct 29 2020, 20:12

Closed by commit rABC0c866043338f: qt: Remove "Pay only required fee" checkbox (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyOct 29 2020, 22:02

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC0c866043338f: qt: Remove "Pay only required fee" checkbox.