Differential D8219

util: Avoid potential uninitialized read in FormatISO8601DateTime(int64_t nTime) by checking gmtime_s/gmtime_r return value
ClosedPublic
Actions

Authored by Fabien on Nov 1 2020, 16:58.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC3bf07d187ae4: util: Avoid potential uninitialized read in FormatISO8601DateTime(int64_t…

Summary

The same goes for other very large positive and negative arguments.

Fix by simply checking the gmtime_s/gmtime_r return value :)

Backport of core PR18162.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR18162

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13798
Build 27615: Build Diff	lint-circular-dependencies · build-diff · build-clang-tidy · build-clang · build-without-wallet · build-debug
Build 27614: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 1 2020, 16:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 1 2020, 16:58

Fabien requested review of this revision.Nov 1 2020, 16:58

teamcity edited the summary of this revision. (Show Details)Nov 1 2020, 16:59

PiRK accepted this revision.Nov 1 2020, 17:09

This revision is now accepted and ready to land.Nov 1 2020, 17:09

Harbormaster completed remote builds in B13798: Diff 25325.Nov 1 2020, 17:11

Closed by commit rABC3bf07d187ae4: util: Avoid potential uninitialized read in FormatISO8601DateTime(int64_t… (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by Fabien). · Explain WhyNov 1 2020, 17:21

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC3bf07d187ae4: util: Avoid potential uninitialized read in FormatISO8601DateTime(int64_t….

Revision Contents
Changeset List

Path

Size

src/

util/

time.cpp

12 lines

Diff 25325

View Options

util: Avoid potential uninitialized read in FormatISO8601DateTime(int64_t nTime) by checking gmtime_s/gmtime_r return valueClosedPublicActions