test: rm ascii art in rpc_fundrawtransaction
ClosedPublic
Actions

Authored by PiRK on Nov 2 2020, 10:36.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABCfde7066c32f3: test: rm ascii art in rpc_fundrawtransaction

Summary

Doc changes only to test/functional/rpc_fundrawtransaction.py:

remove ascii art or convert to a docstring when sufficiently different from the logging

touch up other comments while here

This is a backport of Core PR17327 [2/2]
https://github.com/bitcoin/bitcoin/pull/17327/commits/ff22751417c6fbbd22f4eefd0e23431a83335c13

Depends on D8234

Test Plan

ninja && test/functional/test_runner.py rpc_fundr*
(just in case any typo introduced a SyntaxError)

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 2 2020, 10:36

Owners added a reviewer: Restricted Owners Package.Nov 2 2020, 10:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 2 2020, 10:36

PiRK requested review of this revision.Nov 2 2020, 10:36

teamcity edited the summary of this revision. (Show Details)Nov 2 2020, 10:37

PiRK edited the summary of this revision. (Show Details)Nov 2 2020, 10:37

PiRK added a parent revision: D8234: test: add rpc_fundrawtransaction logging.

Harbormaster completed remote builds in B13815: Diff 25348.Nov 2 2020, 10:49

jasonbcox accepted this revision.Nov 2 2020, 17:18

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

test/functional/rpc_fundrawtransaction.py
795 ↗	(On Diff #25348)	I don't think this is a better place for the comment.

This revision is now accepted and ready to land.Nov 2 2020, 17:18

PiRK added inline comments.Nov 3 2020, 07:21

test/functional/rpc_fundrawtransaction.py
795 ↗	(On Diff #25348)	I don't think this is a better place for the comment. I did not have any strong opinion about the placement, It was just a way to avoid having the linter wrap the comment on 2 lines (81 characters) by putting in a context with less indentation. I can revert if you think it was better to have it in it's previous position.