Page MenuHomePhabricator
Differential D8238

p2p: Avoid allocating memory for addrKnown where we don't need it
ClosedPublic
Actions

Authored by PiRK on Nov 2 2020, 16:39.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC59d4627bec11: p2p: Avoid allocating memory for addrKnown where we don't need it
Summary

We should allocate memory for addrKnown filter only for those peers which are expected to participate in address relay.

Currently, we do it for all peers (including SPV and block-relay-only), which results in extra RAM where it's not needed.

Upd:
In future, we would still allow SPVs to ask for addrs, so allocation still will be done by default.
However, they will be able to opt-out via this proposal and then we could save some more memory.
This PR still saves memory for block-relay-only peers immediately after merging.

We use std::make_unique instead of MakeUnique (see D2463)

This is a backport of Core PR17164 [1/3]
https://github.com/bitcoin/bitcoin/pull/17164/commits/090b75c14be6b9ba2efe38a17d141c6e6af575cb

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 2 2020, 16:39
Owners added a reviewer: Restricted Owners Package.Nov 2 2020, 16:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 2 2020, 16:39
PiRK requested review of this revision.Nov 2 2020, 16:39
teamcity edited the summary of this revision. (Show Details)Nov 2 2020, 16:39
PiRK added a child revision: D8239: added asserts to check m_addr_known when it's used.Nov 2 2020, 16:41
PiRK edited the test plan for this revision. (Show Details)
teamcity edited the summary of this revision. (Show Details)Nov 2 2020, 16:44
Harbormaster completed remote builds in B13818: Diff 25352.Nov 2 2020, 16:49
PiRK edited the summary of this revision. (Show Details)Nov 2 2020, 16:50
Fabien accepted this revision.Nov 3 2020, 10:37
This revision is now accepted and ready to land.Nov 3 2020, 10:37
Closed by commit rABC59d4627bec11: p2p: Avoid allocating memory for addrKnown where we don't need it (authored by User <naumenko.gs@gmail.com>, committed by PiRK). · Explain WhyNov 3 2020, 11:21
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC59d4627bec11: p2p: Avoid allocating memory for addrKnown where we don't need it.

Revision Contents
Changeset List

PathSize
src/
3 lines
6 lines
6 lines
6 lines

Diff 25381

View Options

src/bloom.h

Loading...
View Options

src/net.h

Loading...
View Options

src/net.cpp

Loading...
View Options

src/net_processing.cpp

Loading...