Page MenuHomePhabricator

TestShell: Simplify default setting of num_nodes and return self from setup()
ClosedPublic

Authored by PiRK on Nov 3 2020, 10:45.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC2c6796434180: TestShell: Simplify default setting of num_nodes and return self from setup()
Summary

This allows user to chain setup() to the initializer. test-shell.md code
examples have been updated to reflect this.

The typo related to backquotes used in example code was already fixed in D8247
One of the two code examples in test-shell.md was intentionally left "unchained", because it is useful to illustrate both ways of doing and because our version is much longer due to the necessity of specifying the config.ini path.

This is a backport of Core PR17378

Depends on D8247

Test Plan

ninja && ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable