Paths

Table of Contentst

Differential D8241

Remove network_event_loop instance in close()
ClosedPublic
Actions

Authored by PiRK on Nov 3 2020, 10:18.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABC074c6b258a91: Remove network_event_loop instance in close()

Summary

The asyncio.new_event_loop() instance is now removed from the NetworkThread
class during shutdown. This enables a NetworkThread instance to be restarted
after being closed. The current NetworkThread class guards against an existing
new_event_loop during initialization.

This is a backport of Core PR17288 [1/7]
https://github.com/bitcoin/bitcoin/pull/17288/commits/ede8b7608e115364b5bb12e7f39d662145733de6

Test Plan

ninja && ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 3 2020, 10:18

Owners added a reviewer: Restricted Owners Package.Nov 3 2020, 10:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 3 2020, 10:18

PiRK requested review of this revision.Nov 3 2020, 10:18

teamcity edited the summary of this revision. (Show Details)Nov 3 2020, 10:18

PiRK added a child revision: D8242: Refactor TestFramework main() into setup/shutdown.Nov 3 2020, 10:21

Harbormaster completed remote builds in B13823: Diff 25373.Nov 3 2020, 10:37

Fabien accepted this revision.Nov 3 2020, 10:46

This revision is now accepted and ready to land.Nov 3 2020, 10:46

Closed by commit rABC074c6b258a91: Remove network_event_loop instance in close() (authored by JamesC <james.chiangwu@gmail.com>, committed by PiRK). · Explain WhyNov 3 2020, 13:00

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC074c6b258a91: Remove network_event_loop instance in close().

Revision Contents
Changeset List

Path

Size

test/

functional/

test_framework/

2 lines

Diff 25383

test/functional/test_framework/mininode.py

Loading...