Fix comparison function signature
ClosedPublic
Actions

Authored by PiRK on Nov 5 2020, 12:56.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABC880955003365: Fix comparison function signature

Summary

This commit fixes build on CentOS 7 with GCC 4.8.5
Also for std::swap() header <algorithm> is replaced with <utility> one.

This is a backport of Core PR17364 [1/2]
https://github.com/bitcoin/bitcoin/pull/17634/commits/b66861e2e5e8a49e11e7489cf22c3007bc7082cc

Test Plan

ninja

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 5 2020, 12:56

Owners added a reviewer: Restricted Owners Package.Nov 5 2020, 12:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 5 2020, 12:56

PiRK requested review of this revision.Nov 5 2020, 12:56

teamcity edited the summary of this revision. (Show Details)Nov 5 2020, 12:56

Harbormaster completed remote builds in B13871: Diff 25457.Nov 5 2020, 13:08

PiRK added a child revision: D8282: Use correct C++11 header for std::swap().Nov 5 2020, 13:15

Fabien accepted this revision.Nov 5 2020, 16:59

This revision is now accepted and ready to land.Nov 5 2020, 16:59

Closed by commit rABC880955003365: Fix comparison function signature (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyNov 5 2020, 17:24

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC880955003365: Fix comparison function signature.

Revision Contents
Changeset List

Path

Size

src/

qt/

recentrequeststablemodel.h

3 lines

recentrequeststablemodel.cpp

12 lines

Diff 25473

View Options

src/qt/recentrequeststablemodel.h