Paths

Table of Contentst

Use correct C++11 header for std::swap()
ClosedPublic
Actions

Authored by PiRK on Nov 5 2020, 13:14.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABCff91efd79339: Use correct C++11 header for std::swap()

Summary

This is a backport of Core PR17634 [2/2]
https://github.com/bitcoin/bitcoin/pull/17634/commits/98fbd1cdffaa69357091cc67e959ac21119dfa16

Depends on D8281

The header algorithm is needed in cuckoocache.h for std::find (see PR18565). I'm not sure how Core got away with removing it for multiple months, for us it cause a compiler error.

Test Plan

ninja && ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 5 2020, 13:14

Owners added a reviewer: Restricted Owners Package.Nov 5 2020, 13:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 5 2020, 13:14

PiRK requested review of this revision.Nov 5 2020, 13:14

teamcity edited the summary of this revision. (Show Details)Nov 5 2020, 13:14

PiRK edited the summary of this revision. (Show Details)Nov 5 2020, 13:15

PiRK added a parent revision: D8281: Fix comparison function signature.

PiRK edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B13872: Diff 25458.Nov 5 2020, 13:26

deadalnix accepted this revision.Nov 5 2020, 15:53

This revision is now accepted and ready to land.Nov 5 2020, 15:53

Closed by commit rABCff91efd79339: Use correct C++11 header for std::swap() (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyNov 5 2020, 17:47

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCff91efd79339: Use correct C++11 header for std::swap().

Revision Contents
Changeset List

Path

Size

src/

cuckoocache.h

3 lines

prevector.h

1 line

qt/

bantablemodel.cpp

2 lines

peertablemodel.cpp

2 lines

test/

checkqueue_tests.cpp

1 line

validation.h

1 line

Diff 25476

View Options

src/cuckoocache.h

View Options

src/prevector.h

View Options

src/qt/bantablemodel.cpp

View Options

src/qt/peertablemodel.cpp

View Options

src/test/checkqueue_tests.cpp

View Options

Use correct C++11 header for std::swap()ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 25476

src/cuckoocache.h

src/prevector.h

src/qt/bantablemodel.cpp

src/qt/peertablemodel.cpp

src/test/checkqueue_tests.cpp

src/validation.h

Use correct C++11 header for std::swap()
ClosedPublic
Actions

Revision Contents
Changeset List