Page MenuHomePhabricator

util: Update tinyformat to upstream
ClosedPublic

Authored by PiRK on Nov 6 2020, 17:17.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC75faf303172d: util: Update tinyformat to upstream
Summary

Last update was in 2017.
Updates tinyformat to upstream commit 705e3f4e1de922069bf715746d35bd2364b1f98f.
Re-apply bitcoin specific changes.
No changes that affect our use, as far as I can see, but this gets rid
of the gcc -Wimplicit-fallthrough warnings, at least.

This is a backport of Core PR17682

Test Plan

ninja all check-all

Event Timeline

PiRK requested review of this revision.Nov 6 2020, 17:17
deadalnix requested changes to this revision.Nov 6 2020, 21:08
deadalnix added a subscriber: deadalnix.

There are a bunch of changes in there that are not as per univalue.

src/tinyformat.h
217 ↗(On Diff #25516)

Why is this being reformatted?

This is generally not a part of the codebase we want to take ownrship of more than we strictly need to so we don't want that.

This revision now requires changes to proceed.Nov 6 2020, 21:08

I do not understand what you mean by "as per univalue".

src/tinyformat.h
217 ↗(On Diff #25516)

I first tried to do the usual cherry-pick based backport, but it basically yieled one giant conflict because of all the code style changes we applied on our side.

So I just copy-pasted the new core code into our file, ran our linters, and the resulting diff ended up looking almost perfectly like the Core diff from that commit. I just had some minor whitespaces or comment layout differences to fix. I must have missed that one, I will fix it. But note that this will make our code more different from the Core code, not less.

This revision is now accepted and ready to land.Nov 8 2020, 15:11
This revision was automatically updated to reflect the committed changes.