Page MenuHomePhabricator

tests: Use a default of supports_cli=True (instead of supports_cli=False)
ClosedPublic

Authored by PiRK on Nov 7 2020, 16:12.

Details

Summary

Annotate functional tests supporting bitcoin-cli (--usecli) as such.
Change default supports_cli from False to True.

Before this commit:

$ test/functional/test_runner.py --usecli 2>&1 | cut -f2 -d'|' | grep -E ' (Passed|Skipped) *$' | sort | uniq -c
      8  ✓ Passed  
    138  ○ Skipped 

After:

$ ninja && test/functional/test_runner.py --usecli 2>&1 | cut -f2 -d'|' |     grep -E ' (Passed|Skipped) *$' | sort | uniq -c
[15/15] Linking CXX executable src/qt/bitcoin-qt
     97  ✓ Passed  
     49  ○ Skipped 

This is a backport of Core PR17675 [2/2]
https://github.com/bitcoin/bitcoin/pull/17675/commits/5ac804a9eb0cdbdcff8b50ecfb736f8793cab805

Depends on D8316

Test Plan

ninja && test/functional/test_runner.py --usecli

Diff Detail

Event Timeline

PiRK requested review of this revision.Nov 7 2020, 16:12
PiRK planned changes to this revision.Nov 7 2020, 16:24

I need to investigate why some Core tests work with --usecli, but don't work for us. Maybe timeout issues.

PiRK requested review of this revision.Nov 8 2020, 09:59
This revision is now accepted and ready to land.Nov 8 2020, 15:13