Differential D8327

Remove ValidationState's constructor
ClosedPublic
Actions

Authored by Fabien on Nov 9 2020, 12:34.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC0bc9d84a6c25: Remove ValidationState's constructor

Summary

Partial backport 2/3 of core PR17399:
https://github.com/bitcoin/bitcoin/pull/17399/commits/10e85d4adc9b7dbbda63e00195e0a962f51e4d2c

Depends on D8326.

Test Plan

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR17399_part2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13936
Build 27880: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 27879: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 9 2020, 12:34

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 9 2020, 12:34

Fabien requested review of this revision.Nov 9 2020, 12:35

teamcity edited the summary of this revision. (Show Details)Nov 9 2020, 12:35

Fabien added a child revision: D8328: Templatize ValidationState instead of subclassing.Nov 9 2020, 12:35

majcosta accepted this revision.Nov 9 2020, 12:50

This revision is now accepted and ready to land.Nov 9 2020, 12:50

Harbormaster completed remote builds in B13936: Diff 25568.Nov 9 2020, 12:58

Closed by commit rABC0bc9d84a6c25: Remove ValidationState's constructor (authored by Jeffrey Czyz <jkczyz@gmail.com>, committed by Fabien). · Explain WhyNov 9 2020, 13:50

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC0bc9d84a6c25: Remove ValidationState's constructor.

Revision Contents
Changeset List

Path

Size

src/

consensus/

validation.h

3 lines

Diff 25568

View Options

src/consensus/validation.h

Remove ValidationState's constructorClosedPublicActions