Page MenuHomePhabricator

Templatize ValidationState instead of subclassing
ClosedPublic

Authored by Fabien on Nov 9 2020, 12:35.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC0f17907934bf: Templatize ValidationState instead of subclassing
Summary
This removes boilerplate code in the subclasses which otherwise only
differ by the result type.

Completes backport 3/3 of core PR17399:
https://github.com/bitcoin/bitcoin/pull/17399/commits/10efc0487c442bccb0e4a9ac29452af1592a3cf2

Depends on D8327.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Nov 9 2020, 12:35
majcosta added a subscriber: majcosta.
majcosta added inline comments.
src/consensus/validation.h
83 ↗(On Diff #25569)

instantiated*

This revision is now accepted and ready to land.Nov 9 2020, 13:08