Page MenuHomePhabricator
Differential D8328

Templatize ValidationState instead of subclassing
ClosedPublic
Actions

Authored by Fabien on Nov 9 2020, 12:35.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC0f17907934bf: Templatize ValidationState instead of subclassing
Summary
This removes boilerplate code in the subclasses which otherwise only
differ by the result type.

Completes backport 3/3 of core PR17399:
https://github.com/bitcoin/bitcoin/pull/17399/commits/10efc0487c442bccb0e4a9ac29452af1592a3cf2

Depends on D8327.

Test Plan
ninja all check-all

Diff Detail

Event Timeline

Fabien created this revision.Nov 9 2020, 12:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 9 2020, 12:35
Fabien requested review of this revision.Nov 9 2020, 12:35
teamcity edited the summary of this revision. (Show Details)Nov 9 2020, 12:36
Harbormaster completed remote builds in B13937: Diff 25569.Nov 9 2020, 13:04
majcosta accepted this revision.Nov 9 2020, 13:08
majcosta added a subscriber: majcosta.
majcosta added inline comments.
src/consensus/validation.h
83

instantiated*

This revision is now accepted and ready to land.Nov 9 2020, 13:08
Closed by commit rABC0f17907934bf: Templatize ValidationState instead of subclassing (authored by Jeffrey Czyz <jkczyz@gmail.com>, committed by Fabien). · Explain WhyNov 9 2020, 13:51
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC0f17907934bf: Templatize ValidationState instead of subclassing.

Revision Contents
Changeset List

PathSize
src/
avalanche/
17 lines
consensus/
55 lines

Diff 25569

View Options

src/avalanche/validation.h

Loading...
View Options

src/consensus/validation.h

Loading...