Page MenuHomePhabricator
Differential D8359

Add test for descriptor ranges in wallet_importmulti.py
ClosedPublic
Actions

Authored by deadalnix on Nov 10 2020, 17:39.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC09cc5afe4fb7: Add test for descriptor ranges in wallet_importmulti.py
Summary

This wasn't ported from PR14491 because it used segwit, but this can be done without segwit.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Nov 10 2020, 17:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 10 2020, 17:39
deadalnix requested review of this revision.Nov 10 2020, 17:39
teamcity edited the summary of this revision. (Show Details)Nov 10 2020, 17:39
deadalnix updated this revision to Diff 25639.Nov 10 2020, 17:51

Remove debug log

Harbormaster completed remote builds in B13973: Diff 25638.Nov 10 2020, 17:52
Harbormaster completed remote builds in B13974: Diff 25639.Nov 10 2020, 18:04
PiRK added a subscriber: PiRK.Nov 11 2020, 05:07
PiRK added inline comments.
test/functional/wallet_importmulti.py
506 ↗(On Diff #25639)

There is something weird, here. address is never used in the loop. addresses is not used anywhere else in the test. But it is the same problem in the original PR.

PiRK added inline comments.Nov 11 2020, 05:13
test/functional/wallet_importmulti.py
506 ↗(On Diff #25639)

Core fixes the problem in PR15024:
https://github.com/bitcoin/bitcoin/pull/15024/commits/81a884bbd0dbee108d11776794d9627ca07504aa#diff-a6f3c59a48808c32e3f01dbdd1c72ad1b208b729f277f82128b14abf847e5969L590

I don't know if it should be fixed in this diff, or if we should just make sure to backport 15024 soon. It seems to be a WIP in D7804.

majcosta requested changes to this revision.Nov 11 2020, 16:57
majcosta added a subscriber: majcosta.
majcosta added inline comments.
test/functional/wallet_importmulti.py
508 ↗(On Diff #25639)

I don't think this is right, check lines 525 to 539

This revision now requires changes to proceed.Nov 11 2020, 16:57
majcosta accepted this revision.Nov 12 2020, 13:08
This revision is now accepted and ready to land.Nov 12 2020, 13:08
majcosta mentioned this in D7804: [backport#15024] Allow specific private keys to be derived from descriptor.Nov 12 2020, 14:57
Closed by commit rABC09cc5afe4fb7: Add test for descriptor ranges in wallet_importmulti.py (authored by deadalnix). · Explain WhyNov 12 2020, 15:14
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC09cc5afe4fb7: Add test for descriptor ranges in wallet_importmulti.py.

Revision Contents
Changeset List

PathSize
test/
functional/
22 lines

Diff 25683

View Options

test/functional/wallet_importmulti.py

Loading...