Page MenuHomePhabricator

Add email form to landing page and sub pages
ClosedPublic

Authored by jasonbcox on Nov 15 2020, 01:39.

Details

Reviewers
johnkuney
Fabien
Group Reviewers
Restricted Project
Commits
rABCWEB037f6b044108: Add email form to landing page and sub pages
Summary

As requested from Christabel, adding an email collecting form to the site using Mailerlite.

Inserted their script in the head and added the form to the landing page, releases page and docs page

Test Plan

Submit some test emails and confirm the form is working as intended with Christabel

Diff Detail

Repository
rABCWEB Bitcoin ABC Website
Branch
add-form
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 14054
Build 28113: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.Nov 15 2020, 02:23
deadalnix added a subscriber: deadalnix.

Please edit the diff to use proper description.

This revision now requires changes to proceed.Nov 15 2020, 02:23
johnkuney retitled this revision from add-form to Add email form to landing page and sub pages.Nov 15 2020, 04:12
johnkuney edited the summary of this revision. (Show Details)
jasonbcox requested changes to this revision.Nov 15 2020, 10:01
jasonbcox added a subscriber: jasonbcox.

Similar to docindex, is it possible to add this to the page layout instead of the index and release pages directly?

index.html
28

Since this may be reused multiple times, please add it to _includes and include it accordingly.

releases.html
9

This location is bad because it pushes the hero boxes below the fold.

jasonbcox edited reviewers, added: johnkuney; removed: jasonbcox.
jasonbcox edited the summary of this revision. (Show Details)

Apply my feedback from earlier

Move most of the includes to the footer. This looks better in some cases and puts it on more pages.

This revision is now accepted and ready to land.Nov 15 2020, 10:57
This revision was automatically updated to reflect the committed changes.