Page MenuHomePhabricator

Adding cashtab and draft deploy scripts
Needs RevisionPublic

Authored by josephroyking on Tue, Nov 17, 23:24.

Details

Reviewers
jasonbcox
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

Adding current version of web wallet to bitcoin-abc repo

Test Plan

performance of extract-cashtab.sh should be verified and Dockerfile should be adapted for deployment to wallet.bitcoinabc.org

Diff Detail

Repository
rABC Bitcoin ABC
Branch
adding-cashtab
Lint
Lint ErrorsExcuse: This is a test commit, have not used system before
SeverityLocationCodeMessage
Errorsrc/cashtab/build-ext.sh:BASH_SHEBANG1Missing or unexpected shebang.
Errorsrc/cashtab/build-ext.sh:SHELL_LOCALE1`export LC_ALL=C` or `export LC_ALL=C.UTF-8` should be the first statement.
Unit
No Unit Test Coverage
Build Status
Buildable 14084
Build 28171: Build Diffbuild-without-wallet · build-diff · lint-circular-dependencies · build-clang · build-clang-tidy · build-debug
Build 28170: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Tue, Nov 17, 23:24
deadalnix requested changes to this revision.Wed, Nov 18, 02:12
deadalnix added a subscriber: deadalnix.

This does not looks like it is in an appropriate place in the middle of bitcoind's source code.

This revision now requires changes to proceed.Wed, Nov 18, 02:12
contrib/extract-cashtab.sh
1

Do not duplicate these scripts ad infinitum. It doesn't need to be part of the import anyways, and this crates a maintenance nightmare.

src/cashtab/.editorconfig
19

Th way we achieve this is by having arc lint just do it. I recommend using prettier for the formatting itself.

src/cashtab/.prettierrc
6

It seems surprising that these quot are legal, it is not a legal JSON afaik.

src/cashtab/CHANGELOG.md
1

Isn't it what git is for?

Also, all links are dead.