Differential D8441

Adding cashtab and draft deploy scripts
AbandonedPublic
Actions

Authored by bytesofman on Nov 17 2020, 23:24.

Tags

None

Subscribers

Details

Reviewers

jasonbcox
deadalnix

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Summary

Adding current version of web wallet to bitcoin-abc repo

Test Plan

performance of extract-cashtab.sh should be verified and Dockerfile should be adapted for deployment to wallet.bitcoinabc.org

Diff Detail

Repository

rABC Bitcoin ABC

Branch

adding-cashtab

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/cashtab/build-ext.sh:	BASH_SHEBANG1	Missing or unexpected shebang.
Error	src/cashtab/build-ext.sh:	SHELL_LOCALE1	`export LC_ALL=C` or `export LC_ALL=C.UTF-8` should be the first statement.

Unit

No Test Coverage

Build Status

Buildable 14084
Build 28171: Build Diff	build-without-wallet · build-diff · lint-circular-dependencies · build-clang · build-clang-tidy · build-debug
Build 28170: arc lint + arc unit

Event Timeline

bytesofman created this revision.Nov 17 2020, 23:24

Owners added a reviewer: Restricted Owners Package.Nov 17 2020, 23:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 17 2020, 23:24

bytesofman requested review of this revision.Nov 17 2020, 23:24

Harbormaster completed remote builds in B14084: Diff 25828.Nov 17 2020, 23:24

This does not looks like it is in an appropriate place in the middle of bitcoind's source code.

This revision now requires changes to proceed.Nov 18 2020, 02:12

deadalnix added inline comments.Nov 18 2020, 22:54

contrib/extract-cashtab.sh
1	Do not duplicate these scripts ad infinitum. It doesn't need to be part of the import anyways, and this crates a maintenance nightmare.
src/cashtab/.editorconfig
19	Th way we achieve this is by having arc lint just do it. I recommend using prettier for the formatting itself.
src/cashtab/.prettierrc
6	It seems surprising that these quot are legal, it is not a legal JSON afaik.
src/cashtab/CHANGELOG.md
1	Isn't it what git is for? Also, all links are dead.

jasonbcox mentioned this in D8471: [buildbot] Introduce selecting diff builds based on filename regex.Nov 19 2020, 18:03

jasonbcox mentioned this in rABC96022ff9077a: [buildbot] Introduce selecting diff builds based on filename regex.Nov 20 2020, 16:12

bytesofman abandoned this revision.Aug 3 2021, 19:45

Large Diff

This large diff affects 110 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

Path

Size

contrib/

extract-cashtab.sh

48 lines

src/

cashtab/

19 lines

3 lines

30 lines

1 line

7 lines

.vscode/

19 lines

153 lines

CONTRIBUTING.md

88 lines

4 lines

57 lines

19 lines

config/

93 lines

jest/

cssTransform.js

14 lines

fileTransform.js

40 lines

88 lines

84 lines

35 lines

webpack.config.js

730 lines

webpackDevServer.config.js

104 lines

41 lines

193 lines

public/

browserconfig.xml

2 lines

52 lines

35 lines

manifestExtension.json

21 lines

2 lines

screenshots/

scripts/

178 lines

145 lines

53 lines

src/

assets/

12-bitcoin-cash-square-crop.svg

1 line

4-bitcoin-cash-logo-flag.svg

1 line

bitcoinabclogo.png

fonts/

RobotoMono-Regular.ttf

hammer-solid.svg

1 line

ios-paperplane.svg

49 lines

simple-ledger-protocol-logo.png

slp-sticker.jpg

components/

408 lines

228 lines

Common/

108 lines

CustomSpinner.js

13 lines

EnhancedInputs.js

148 lines

PrimaryButton.js

85 lines

174 lines

150 lines

StyledCollapse.js

20 lines

StyledOnBoarding.js

57 lines

50 lines

16 lines

__mocks__/

copy-to-clipboard.js

2 lines

__tests__/

CustomIcons.test.js

23 lines

50 lines

StyledCollapse.test.js

12 lines

StyledOnBoarding.test.js

12 lines

StyledPage.test.js

12 lines

__snapshots__/

CustomIcons.test.js.snap

105 lines

StyledCollapse.test.js.snap

8 lines

StyledOnBoarding.test.js.snap

7 lines

StyledPage.test.js.snap

7 lines

Configure/

136 lines

__tests__/

Configure.test.js

33 lines

__snapshots__/

Configure.test.js.snap

365 lines

10 lines

OnBoarding/

111 lines

Send/

320 lines

253 lines

Wallet/

23 lines

TokenListItem.js

75 lines

256 lines

__mocks__/

walletAndBalancesMock.js

60 lines

__tests__/

73 lines

__snapshots__/

Wallet.test.js.snap

428 lines

__tests__/

NotFound.test.js

12 lines

__snapshots__/

NotFound.test.js.snap

17 lines

hooks/

__mocks__/

mockReturnGetSlpBalancesAndUtxos.js

81 lines

27 lines

tokenDetailsResponse.js

47 lines

utxoResponseFromElectrum.js

33 lines

__tests__/

130 lines

useAsyncTimeout.js

34 lines

641 lines

180 lines

useInnerScroll.js

7 lines

20 lines

17 lines

691 lines

useWindowDimensions.js

27 lines

11 lines

25 lines

serviceWorker.js

44 lines

utils/

7 lines

13 lines

12 lines

14531 lines

Diff 25828

contrib/extract-cashtab.sh

Loading...

src/cashtab/.editorconfig

Loading...

src/cashtab/.env

src/cashtab/.gitignore

src/cashtab/.nvmrc

src/cashtab/.prettierrc

Loading...

src/cashtab/.vscode/launch.json

src/cashtab/CHANGELOG.md

Loading...

src/cashtab/CONTRIBUTING.md

src/cashtab/Dockerfile

src/cashtab/README.md

src/cashtab/build-ext.sh

src/cashtab/config/env.js

src/cashtab/config/jest/cssTransform.js

src/cashtab/config/jest/fileTransform.js

src/cashtab/config/modules.js

src/cashtab/config/paths.js

src/cashtab/config/pnpTs.js

src/cashtab/config/webpack.config.js

src/cashtab/config/webpackDevServer.config.js

src/cashtab/manifest.json

src/cashtab/package.json

src/cashtab/public/bch128.png

src/cashtab/public/bch16.png

src/cashtab/public/bch192.png

src/cashtab/public/bch48.png

src/cashtab/public/bch512.png

src/cashtab/public/browserconfig.xml

src/cashtab/public/favicon.ico

src/cashtab/public/index.html

src/cashtab/public/manifest.json

src/cashtab/public/manifestExtension.json

src/cashtab/public/robots.txt

src/cashtab/screenshots/ss01.png

src/cashtab/screenshots/ss02.png

src/cashtab/screenshots/ss03.png

src/cashtab/screenshots/ss04.jpg

src/cashtab/scripts/build.js

src/cashtab/scripts/start.js

src/cashtab/scripts/test.js

src/cashtab/src/assets/12-bitcoin-cash-square-crop.svg

src/cashtab/src/assets/4-bitcoin-cash-logo-flag.svg

src/cashtab/src/assets/bitcoinabclogo.png

src/cashtab/src/assets/cashtab.png

src/cashtab/src/assets/fonts/RobotoMono-Regular.ttf

src/cashtab/src/assets/hammer-solid.svg

src/cashtab/src/assets/ios-paperplane.svg

src/cashtab/src/assets/simple-ledger-protocol-logo.png

src/cashtab/src/assets/slp-logo-2.png

src/cashtab/src/assets/slp-logo.png

src/cashtab/src/assets/slp-oval.png

src/cashtab/src/assets/slp-qrcode.png

src/cashtab/src/assets/slp-sticker.jpg

src/cashtab/src/components/App.css

src/cashtab/src/components/App.js

src/cashtab/src/components/Common/CustomIcons.js

src/cashtab/src/components/Common/CustomSpinner.js

src/cashtab/src/components/Common/EnhancedInputs.js

src/cashtab/src/components/Common/PrimaryButton.js

src/cashtab/src/components/Common/QRCode.js

src/cashtab/src/components/Common/ScanQRCode.js

src/cashtab/src/components/Common/StyledCollapse.js

src/cashtab/src/components/Common/StyledOnBoarding.js

src/cashtab/src/components/Common/StyledPage.js

src/cashtab/src/components/Common/Ticker.js

src/cashtab/src/components/Common/mocks/copy-to-clipboard.js

src/cashtab/src/components/Common/tests/CustomIcons.test.js

src/cashtab/src/components/Common/tests/QRCode.test.js

src/cashtab/src/components/Common/tests/StyledCollapse.test.js

src/cashtab/src/components/Common/tests/StyledOnBoarding.test.js

src/cashtab/src/components/Common/tests/StyledPage.test.js

src/cashtab/src/components/Common/tests/snapshots/CustomIcons.test.js.snap

src/cashtab/src/components/Common/tests/snapshots/StyledCollapse.test.js.snap

src/cashtab/src/components/Common/tests/snapshots/StyledOnBoarding.test.js.snap

src/cashtab/src/components/Common/tests/snapshots/StyledPage.test.js.snap

src/cashtab/src/components/Configure/Configure.js

src/cashtab/src/components/Configure/tests/Configure.test.js

src/cashtab/src/components/Configure/tests/snapshots/Configure.test.js.snap

src/cashtab/src/components/NotFound.js

src/cashtab/src/components/OnBoarding/OnBoarding.js

src/cashtab/src/components/Send/Send.js

src/cashtab/src/components/Send/SendToken.js

src/cashtab/src/components/Wallet/TokenList.js

src/cashtab/src/components/Wallet/TokenListItem.js

src/cashtab/src/components/Wallet/Wallet.js

src/cashtab/src/components/Wallet/mocks/walletAndBalancesMock.js

src/cashtab/src/components/Wallet/tests/Wallet.test.js

src/cashtab/src/components/Wallet/tests/snapshots/Wallet.test.js.snap

src/cashtab/src/components/tests/NotFound.test.js

src/cashtab/src/components/tests/snapshots/NotFound.test.js.snap

src/cashtab/src/hooks/mocks/mockReturnGetSlpBalancesAndUtxos.js

src/cashtab/src/hooks/mocks/sendBCH.js

src/cashtab/src/hooks/mocks/tokenDetailsResponse.js

src/cashtab/src/hooks/mocks/utxoResponseFromElectrum.js

src/cashtab/src/hooks/tests/useBCH.test.js

src/cashtab/src/hooks/useAsyncTimeout.js

src/cashtab/src/hooks/useBCH.js

src/cashtab/src/hooks/useImage.js

src/cashtab/src/hooks/useInnerScroll.js

src/cashtab/src/hooks/useInterval.js

src/cashtab/src/hooks/usePrevious.js

src/cashtab/src/hooks/useWallet.js

src/cashtab/src/hooks/useWindowDimensions.js

src/cashtab/src/index.css

src/cashtab/src/index.js

src/cashtab/src/serviceWorker.js

src/cashtab/src/utils/context.js

src/cashtab/src/utils/debounce.js

src/cashtab/src/utils/retry.js

src/cashtab/yarn.lock