Change GetMetadata to use unique_ptr<CKeyMetadata>
ClosedPublic
Actions

Authored by deadalnix on Nov 19 2020, 00:06.

Details

Reviewers

Fabien
majcosta

Group Reviewers

Restricted Project

Commits

rABCf18cf5b36037: Change GetMetadata to use unique_ptr<CKeyMetadata>

Summary

Backport of Core PR16528 [31/43] : https://github.com/bitcoin/bitcoin/pull/16528/commits/8b9603bd0b443e2f7984eb72bf2e21cf02af0bcb

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr16528-31

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14097
Build 28196: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 28195: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 19 2020, 00:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 19 2020, 00:06

deadalnix requested review of this revision.Nov 19 2020, 00:06

teamcity edited the summary of this revision. (Show Details)Nov 19 2020, 00:06

deadalnix added a child revision: D8454: Implement GetMetadata in DescriptorScriptPubKeyMan.Nov 19 2020, 00:12

Harbormaster completed remote builds in B14097: Diff 25854.Nov 19 2020, 00:17

Fabien accepted this revision.Nov 19 2020, 08:33

This revision is now accepted and ready to land.Nov 19 2020, 08:33

majcosta accepted this revision.Nov 19 2020, 08:43

Closed by commit rABCf18cf5b36037: Change GetMetadata to use unique_ptr<CKeyMetadata> (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyNov 19 2020, 13:37

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCf18cf5b36037: Change GetMetadata to use unique_ptr<CKeyMetadata>.

Revision Contents
Changeset List

Path

Size

src/

wallet/

rpcwallet.cpp

3 lines

scriptpubkeyman.h

9 lines

scriptpubkeyman.cpp

8 lines

Diff 25854

View Options

src/wallet/rpcwallet.cpp

View Options

src/wallet/scriptpubkeyman.h

View Options

src/wallet/scriptpubkeyman.cpp

Change GetMetadata to use unique_ptr<CKeyMetadata>ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 25854

src/wallet/rpcwallet.cpp

src/wallet/scriptpubkeyman.h

src/wallet/scriptpubkeyman.cpp

Change GetMetadata to use unique_ptr<CKeyMetadata>
ClosedPublic
Actions

Revision Contents
Changeset List