Differential D8492

[qt] remove deprecated Qt:SystemLocale____Date
ClosedPublic
Actions

Authored by majcosta on Nov 21 2020, 05:15.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC918700e98990: [qt] remove deprecated Qt:SystemLocale____Date

Summary

replace with QLocale().dateFormat(), introduced in Qt 4.1

Test Plan

ninja all check check-functional
bitcoin-qt

check the dates look alright

Diff Detail

Repository

rABC Bitcoin ABC

Branch

deprecated_qt_date_functions

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14150
Build 28293: Build Diff	build-without-wallet · build-diff · build-clang-tidy · lint-circular-dependencies · build-clang · build-debug
Build 28292: arc lint + arc unit

Event Timeline

majcosta created this revision.Nov 21 2020, 05:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 21 2020, 05:15

majcosta requested review of this revision.Nov 21 2020, 05:15

Harbormaster completed remote builds in B14150: Diff 25936.Nov 21 2020, 05:27

majcosta added a child revision: D8493: [cpp] move to C++17.Nov 21 2020, 09:01

Fabien accepted this revision.Nov 21 2020, 09:52

This revision is now accepted and ready to land.Nov 21 2020, 09:52

Closed by commit rABC918700e98990: [qt] remove deprecated Qt:SystemLocale____Date (authored by majcosta). · Explain WhyNov 21 2020, 09:59

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC918700e98990: [qt] remove deprecated Qt:SystemLocale____Date.

PiRK mentioned this in D8696: gui: Drop BanTableModel dependency to ClientModel.Dec 18 2020, 13:17

PiRK mentioned this in rABCd186cd85cb2f: gui: Drop BanTableModel dependency to ClientModel.Dec 18 2020, 19:31

Revision Contents
Changeset List

Path

Size

src/

qt/

bantablemodel.cpp

2 lines

guiutil.cpp

4 lines

Diff 25936

View Options

src/qt/bantablemodel.cpp