Debian buster ships with gcc 7/8 which is all green according to:
https://gcc.gnu.org/projects/cxx-status.html
edit: backported some changes from Core PR18591 regarding implicit conversion between Span types
Details
Details
- Reviewers
Fabien deadalnix - Group Reviewers
Restricted Project - Commits
- rABC1541dc4c01d3: [cpp] move to C++17
ninja all check test_runner.py --extended
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- require_cpp17
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 14152 Build 28297: Build Diff lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang · build-clang-tidy Build 28296: arc lint + arc unit
Event Timeline
Comment Actions
You are missing the documentation update and maybe a release note.
Also what about clang ?
| src/test/util_tests.cpp | ||
|---|---|---|
| 2147 ↗ | (On Diff #25944) | Why? |
| src/test/util_tests.cpp | ||
|---|---|---|
| 2147 ↗ | (On Diff #25944) | I was getting the error below and using string_view seemed to fix it: Candidate function (the implicit copy assignment operator) not viable: no known conversion from 'Span<typename std::remove_pointer<decltype(std::declval<basic_string<char>>().data())>::type>' to 'const Span<const char>' for 1st argument BUT, I've checked and it seems like Core has probably ran into similar issues when going into C++17, I'll backport their solution, if it exists. |
| doc/release-notes.md | ||
|---|---|---|
| 8 ↗ | (On Diff #25951) | Remove |
| src/span.h | ||
|---|---|---|
| 28 ↗ | (On Diff #25951) | fix layout |