Don't specify the C++ standard explicitely for Cppcheck
ClosedPublic
Actions

Authored by Fabien on Nov 24 2020, 20:53.

Details

Reviewers

majcosta
jasonbcox

Group Reviewers

Restricted Project

Commits

rABC725cad26a56a: Don't specify the C++ standard explicitely for Cppcheck

Summary

Cppcheck defaults the most recent standard by default, and this will
prevent from failing if the very latest cppcheck version is not used.

Test Plan

arc lint --everything

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cppcheck_no_cpp17

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14190
Build 28364: Build Diff
Build 28363: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 24 2020, 20:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 24 2020, 20:53

Fabien requested review of this revision.Nov 24 2020, 20:53

Harbormaster completed remote builds in B14190: Diff 26009.Nov 24 2020, 20:53

majcosta accepted this revision.Nov 24 2020, 20:58

This revision is now accepted and ready to land.Nov 24 2020, 20:58

jasonbcox accepted this revision.Nov 24 2020, 21:01

Closed by commit rABC725cad26a56a: Don't specify the C++ standard explicitely for Cppcheck (authored by Fabien). · Explain WhyNov 24 2020, 21:01

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC725cad26a56a: Don't specify the C++ standard explicitely for Cppcheck.

Revision Contents
Changeset List

Path

Size

arcanist/

linter/

CppCheckLinter.php

1 line

Diff 26009

View Options

arcanist/linter/CppCheckLinter.php

Don't specify the C++ standard explicitely for CppcheckClosedPublicActions