Page MenuHomePhabricator
Differential D8519

util: simplify the interface of serviceFlagToStr()
ClosedPublic
Actions

Authored by Fabien on Nov 24 2020, 22:46.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC3114174d8810: util: simplify the interface of serviceFlagToStr()
Summary
Don't take two redundant arguments in `serviceFlagToStr()`.

As a side effect this fixes an issue introduced in
https://github.com/bitcoin/bitcoin/pull/18165 due to which the GUI could
print something like `UNKNOWN[1033] & UNKNOWN[1033] & UNKNOWN[2^10]`
instead of `NETWORK & WITNESS`.

util: dedup code in callers of serviceFlagToStr()

Backport of core PR19106.

Depends on D8518.

Test Plan
ninja all check-all

./src/qt/bitcoin-qt -server

Check the service bits display correctly

./src/bitcoin-cli getnetworkinfo

Check the service bits display correctly

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 24 2020, 22:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 24 2020, 22:46
Fabien requested review of this revision.Nov 24 2020, 22:46
teamcity edited the summary of this revision. (Show Details)Nov 24 2020, 22:46
Harbormaster completed remote builds in B14194: Diff 26014.Nov 24 2020, 22:47
Fabien updated this revision to Diff 26019.Nov 25 2020, 00:12

Rebase

Harbormaster completed remote builds in B14198: Diff 26019.Nov 25 2020, 00:12
deadalnix accepted this revision.Nov 25 2020, 03:37
This revision is now accepted and ready to land.Nov 25 2020, 03:37
Fabien updated this revision to Diff 26026.Nov 25 2020, 08:21

Rebase

Harbormaster completed remote builds in B14204: Diff 26026.Nov 25 2020, 08:46
teamcity added a comment.Nov 25 2020, 08:46
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: p2p_timeouts.py ======

------- Stdout: -------
2020-11-25T08:44:20.908000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201125_084348/p2p_timeouts_274
2020-11-25T08:44:28.409000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 120, in main
    self.run_test()
  File "/work/test/functional/p2p_timeouts.py", line 91, in run_test
    assert not no_send_node.is_connected
  File "/usr/lib/python3.7/contextlib.py", line 119, in __exit__
    next(self.gen)
  File "/work/test/functional/test_framework/test_node.py", line 467, in assert_debug_log
    str(expected_msgs), print_log))
  File "/work/test/functional/test_framework/test_node.py", line 203, in _raise_assertion_error
    raise AssertionError(self._node_msg(msg))
AssertionError: [node 0] Expected messages "['version handshake timeout from 0', 'socket no message in first 3 seconds, 1 0 from 1', 'socket no message in first 3 seconds, 0 0 from 2']" does not partially match log:

 - 


2020-11-25T08:44:28.461000Z TestFramework (INFO): Stopping nodes
2020-11-25T08:44:28.713000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201125_084348/p2p_timeouts_274
2020-11-25T08:44:28.713000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201125_084348/p2p_timeouts_274/test_framework.log
2020-11-25T08:44:28.713000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201125_084348/p2p_timeouts_274' to consolidate all logs

Each failure log is accessible here:
Bitcoin ABC functional tests: p2p_timeouts.py

Fabien added a comment.Nov 25 2020, 09:14

unrelated failure

Fabien added a child revision: D8526: rpc: Remove special case for unknown service flags.Nov 25 2020, 15:57
Fabien updated this revision to Diff 26032.Nov 25 2020, 16:39

Rebase

This revision was landed with ongoing or failed builds.Nov 25 2020, 16:44
Closed by commit rABC3114174d8810: util: simplify the interface of serviceFlagToStr() (authored by Vasil Dimov <vd@FreeBSD.org>, committed by Fabien). · Explain Why
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC3114174d8810: util: simplify the interface of serviceFlagToStr().
teamcity added a comment.Nov 25 2020, 17:01
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

[316/492] Building CXX object src/CMakeFiles/common.dir/key_io.cpp.o
[317/492] Building C object src/secp256k1/CMakeFiles/sign-bench.dir/src/bench_sign.c.o
[318/492] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[319/492] Building C object src/secp256k1/CMakeFiles/verify-bench.dir/src/bench_verify.c.o
[320/492] Building C object src/secp256k1/CMakeFiles/recover-bench.dir/src/bench_recover.c.o
[321/492] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[322/492] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[323/492] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[324/492] Linking C static library src/secp256k1/libsecp256k1.a
[325/492] Linking C executable src/secp256k1/ecmult-bench
[326/492] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[327/492] Linking C executable src/secp256k1/internal-bench
[328/492] Linking C executable src/secp256k1/sign-bench
[329/492] Linking C executable src/secp256k1/verify-bench
[330/492] Building CXX object src/CMakeFiles/common.dir/networks/abc/checkpoints.cpp.o
[331/492] Installing component secp256k1
-- Install configuration: "RelWithDebInfo"
-- Install component: "secp256k1"
-- Installing: /results/artifacts/lib/libsecp256k1.a
-- Installing: /results/artifacts/include/secp256k1.h
-- Installing: /results/artifacts/include/secp256k1_preallocated.h
-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[332/492] Linking C executable src/secp256k1/recover-bench
[333/492] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[334/492] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[335/492] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[336/492] Building CXX object src/CMakeFiles/common.dir/rpc/rawtransaction_util.cpp.o
[337/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[338/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[339/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[340/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[341/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[342/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[343/492] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[344/492] Building CXX object src/CMakeFiles/common.dir/rpc/util.cpp.o
[345/492] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[346/492] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[347/492] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[348/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[349/492] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[350/492] Building CXX object src/seeder/CMakeFiles/seeder.dir/bitcoin.cpp.o
[351/492] Building CXX object src/seeder/CMakeFiles/seeder.dir/dns.cpp.o
[352/492] Building CXX object src/CMakeFiles/script.dir/script/descriptor.cpp.o
[353/492] Linking CXX static library src/libscript.a
[354/492] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[355/492] Building CXX object src/seeder/CMakeFiles/seeder.dir/db.cpp.o
[356/492] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[357/492] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[358/492] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[359/492] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[360/492] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[361/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[362/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[363/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[364/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[365/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[366/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1
Harbormaster completed remote builds in B14209: Diff 26032.Nov 25 2020, 17:01
teamcity added a comment.Nov 25 2020, 17:02
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Tail of the build log:

[316/492] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/uint256.cpp.o
[317/492] Building C object src/secp256k1/CMakeFiles/sign-bench.dir/src/bench_sign.c.o
[318/492] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/primitives/transaction.cpp.o
[319/492] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/util/strencodings.cpp.o
[320/492] Building C object src/secp256k1/CMakeFiles/verify-bench.dir/src/bench_verify.c.o
[321/492] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/tx_check.cpp.o
[322/492] Building C object src/secp256k1/CMakeFiles/recover-bench.dir/src/bench_recover.c.o
[323/492] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/pubkey.cpp.o
[324/492] Building CXX object src/CMakeFiles/script.dir/script/standard.cpp.o
[325/492] Building CXX object src/CMakeFiles/script.dir/script/sign.cpp.o
[326/492] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[327/492] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[328/492] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[329/492] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[330/492] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[331/492] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[332/492] Linking C static library src/secp256k1/libsecp256k1.a
[333/492] Linking C executable src/secp256k1/ecmult-bench
[334/492] Building CXX object src/CMakeFiles/script.dir/script/signingprovider.cpp.o
[335/492] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[336/492] Linking C executable src/secp256k1/internal-bench
[337/492] Linking C executable src/secp256k1/sign-bench
[338/492] Linking C executable src/secp256k1/verify-bench
[339/492] Linking C executable src/secp256k1/recover-bench
[340/492] Installing component secp256k1
-- Install configuration: "Debug"
-- Install component: "secp256k1"
-- Installing: /results/artifacts/lib/libsecp256k1.a
-- Installing: /results/artifacts/include/secp256k1.h
-- Installing: /results/artifacts/include/secp256k1_preallocated.h
-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[341/492] Building CXX object src/CMakeFiles/script.dir/script/descriptor.cpp.o
[342/492] Linking CXX static library src/libscript.a
[343/492] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[344/492] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[345/492] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[346/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[347/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[348/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[349/492] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[350/492] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[351/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[352/492] Building CXX object src/seeder/CMakeFiles/seeder.dir/bitcoin.cpp.o
[353/492] Building CXX object src/seeder/CMakeFiles/seeder.dir/db.cpp.o
[354/492] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[355/492] Building CXX object src/seeder/CMakeFiles/seeder.dir/dns.cpp.o
[356/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[357/492] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[358/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[359/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[360/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[361/492] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[362/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[363/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[364/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[365/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[366/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1
teamcity added a comment.Nov 25 2020, 17:03
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

[308/490] Building CXX object src/CMakeFiles/util.dir/util/moneystr.cpp.o
[309/490] Building CXX object src/CMakeFiles/util.dir/util/threadnames.cpp.o
[310/490] Building CXX object src/CMakeFiles/util.dir/util/url.cpp.o
[311/490] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/arith_uint256.cpp.o
[312/490] Building CXX object src/CMakeFiles/util.dir/rpc/request.cpp.o
[313/490] Building CXX object src/CMakeFiles/util.dir/util/strencodings.cpp.o
[314/490] Linking C static library src/secp256k1/libsecp256k1.a
[315/490] Linking C executable src/secp256k1/ecmult-bench
[316/490] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/hash.cpp.o
[317/490] Linking C executable src/secp256k1/internal-bench
[318/490] Linking C executable src/secp256k1/sign-bench
[319/490] Linking C executable src/secp256k1/verify-bench
[320/490] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/uint256.cpp.o
[321/490] Linking C executable src/secp256k1/recover-bench
[322/490] Building CXX object src/CMakeFiles/util.dir/blockdb.cpp.o
[323/490] Building CXX object src/CMakeFiles/util.dir/util/error.cpp.o
[324/490] Building CXX object src/CMakeFiles/util.dir/util/message.cpp.o
[325/490] Building CXX object src/CMakeFiles/util.dir/util/settings.cpp.o
[326/490] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/primitives/transaction.cpp.o
[327/490] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/util/strencodings.cpp.o
[328/490] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/pubkey.cpp.o
[329/490] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[330/490] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/tx_check.cpp.o
[331/490] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[332/490] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[333/490] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[334/490] Building CXX object src/CMakeFiles/util.dir/util/time.cpp.o
[335/490] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[336/490] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[337/490] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[338/490] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[339/490] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[340/490] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[341/490] Building CXX object src/CMakeFiles/util.dir/util/system.cpp.o
[342/490] Linking CXX static library src/libutil.a
[343/490] Linking CXX static library src/libscript.a
[344/490] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqabstractnotifier.cpp.o
[345/490] Linking CXX static library src/librpcclient.a
[346/490] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[347/490] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[348/490] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[349/490] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[350/490] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[351/490] Building CXX object src/seeder/CMakeFiles/seeder.dir/dns.cpp.o
[352/490] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[353/490] Building CXX object src/seeder/CMakeFiles/seeder.dir/bitcoin.cpp.o
[354/490] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqnotificationinterface.cpp.o
[355/490] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqpublishnotifier.cpp.o
[356/490] Building CXX object src/seeder/CMakeFiles/seeder.dir/db.cpp.o
[357/490] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[358/490] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqrpc.cpp.o
[359/490] Linking CXX static library src/zmq/libzmq.a
[360/490] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[361/490] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[362/490] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[363/490] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[364/490] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[365/490] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
teamcity added a comment.Nov 25 2020, 17:04
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

[316/492] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/pubkey.cpp.o
[317/492] Building C object src/secp256k1/CMakeFiles/sign-bench.dir/src/bench_sign.c.o
[318/492] Building C object src/secp256k1/CMakeFiles/recover-bench.dir/src/bench_recover.c.o
[319/492] Building C object src/secp256k1/CMakeFiles/verify-bench.dir/src/bench_verify.c.o
[320/492] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/tx_check.cpp.o
[321/492] Building CXX object src/CMakeFiles/script.dir/script/interpreter.cpp.o
[322/492] Building CXX object src/CMakeFiles/script.dir/script/sign.cpp.o
[323/492] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/primitives/transaction.cpp.o
[324/492] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/util/strencodings.cpp.o
[325/492] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[326/492] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[327/492] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[328/492] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[329/492] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[330/492] Building CXX object src/CMakeFiles/script.dir/script/signingprovider.cpp.o
[331/492] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[332/492] Linking C static library src/secp256k1/libsecp256k1.a
[333/492] Linking C executable src/secp256k1/ecmult-bench
[334/492] Linking C executable src/secp256k1/internal-bench
[335/492] Linking C executable src/secp256k1/sign-bench
[336/492] Linking C executable src/secp256k1/verify-bench
[337/492] Linking C executable src/secp256k1/recover-bench
[338/492] Installing component secp256k1
-- Install configuration: "RelWithDebInfo"
-- Install component: "secp256k1"
-- Installing: /results/artifacts/lib/libsecp256k1.a
-- Installing: /results/artifacts/include/secp256k1.h
-- Installing: /results/artifacts/include/secp256k1_preallocated.h
-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[339/492] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[340/492] Building CXX object src/CMakeFiles/script.dir/script/descriptor.cpp.o
[341/492] Linking CXX static library src/libscript.a
[342/492] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[343/492] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[344/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[345/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[346/492] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[347/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[348/492] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[349/492] Linking CXX static library src/zmq/libzmq.a
[350/492] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[351/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[352/492] Building CXX object src/seeder/CMakeFiles/seeder.dir/bitcoin.cpp.o
[353/492] Building CXX object src/seeder/CMakeFiles/seeder.dir/dns.cpp.o
[354/492] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[355/492] Building CXX object src/seeder/CMakeFiles/seeder.dir/db.cpp.o
[356/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[357/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[358/492] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[359/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[360/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[361/492] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[362/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[363/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[364/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[365/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[366/492] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1
teamcity added a comment.Nov 25 2020, 17:05
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Tail of the build log:

[292/442] Building CXX object src/CMakeFiles/server.dir/node/coinstats.cpp.o
[293/442] Building CXX object src/CMakeFiles/server.dir/policy/settings.cpp.o
[294/442] Building CXX object src/CMakeFiles/server.dir/pow/daa.cpp.o
[295/442] Building CXX object src/CMakeFiles/server.dir/index/blockfilterindex.cpp.o
[296/442] Building CXX object src/CMakeFiles/server.dir/index/txindex.cpp.o
[297/442] Building CXX object src/CMakeFiles/server.dir/rpc/misc.cpp.o
[298/442] Building CXX object src/CMakeFiles/server.dir/interfaces/node.cpp.o
[299/442] Building CXX object src/CMakeFiles/server.dir/rpc/command.cpp.o
[300/442] Building CXX object src/CMakeFiles/server.dir/pow/grasberg.cpp.o
[301/442] Building CXX object src/CMakeFiles/server.dir/pow/eda.cpp.o
[302/442] Building CXX object src/CMakeFiles/server.dir/pow/pow.cpp.o
[303/442] Building CXX object src/CMakeFiles/server.dir/shutdown.cpp.o
[304/442] Building CXX object src/CMakeFiles/server.dir/pow/aserti32d.cpp.o
[305/442] Building CXX object src/CMakeFiles/server.dir/node/transaction.cpp.o
[306/442] Building CXX object src/CMakeFiles/server.dir/timedata.cpp.o
[307/442] Building CXX object src/CMakeFiles/server.dir/script/sigcache.cpp.o
[308/442] Building CXX object src/CMakeFiles/server.dir/net.cpp.o
[309/442] Building CXX object src/CMakeFiles/server.dir/script/scriptcache.cpp.o
[310/442] Building CXX object src/CMakeFiles/server.dir/rpc/abc.cpp.o
[311/442] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[312/442] Building CXX object src/CMakeFiles/server.dir/rest.cpp.o
[313/442] Building CXX object src/CMakeFiles/server.dir/validationinterface.cpp.o
[314/442] Building CXX object src/CMakeFiles/server.dir/versionbits.cpp.o
[315/442] Building C object src/secp256k1/CMakeFiles/sign-bench.dir/src/bench_sign.c.o
[316/442] Building C object src/secp256k1/CMakeFiles/verify-bench.dir/src/bench_verify.c.o
[317/442] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[318/442] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[319/442] Building CXX object src/CMakeFiles/server.dir/dummywallet.cpp.o
[320/442] Building CXX object src/CMakeFiles/server.dir/txdb.cpp.o
[321/442] Building C object src/secp256k1/CMakeFiles/recover-bench.dir/src/bench_recover.c.o
[322/442] Building CXX object src/CMakeFiles/server.dir/rpc/server.cpp.o
[323/442] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[324/442] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[325/442] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[326/442] Linking CXX static library src/zmq/libzmq.a
[327/442] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[328/442] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[329/442] Linking C static library src/secp256k1/libsecp256k1.a
[330/442] Linking C executable src/secp256k1/ecmult-bench
[331/442] Linking C executable src/secp256k1/internal-bench
[332/442] Linking C executable src/secp256k1/sign-bench
[333/442] Linking C executable src/secp256k1/verify-bench
[334/442] Linking C executable src/secp256k1/recover-bench
[335/442] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[336/442] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[337/442] Building CXX object src/seeder/CMakeFiles/seeder.dir/dns.cpp.o
[338/442] Building CXX object src/CMakeFiles/server.dir/rpc/mining.cpp.o
[339/442] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
[340/442] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[341/442] Building CXX object src/seeder/CMakeFiles/seeder.dir/bitcoin.cpp.o
[342/442] Building CXX object src/seeder/CMakeFiles/seeder.dir/db.cpp.o
[343/442] Building CXX object src/CMakeFiles/server.dir/ui_interface.cpp.o
[344/442] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[345/442] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[346/442] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[347/442] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[348/442] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[349/442] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1

Revision Contents
Changeset List

PathSize
src/
7 lines
22 lines
qt/
13 lines
rpc/
8 lines

Diff 26036

View Options

src/protocol.h

Loading...
View Options

src/protocol.cpp

Loading...
View Options

src/qt/guiutil.cpp

Loading...
View Options

src/rpc/util.cpp

Loading...