Page MenuHomePhabricator
Differential D8518

Consolidate service flag bit-to-name conversion to a shared serviceFlagToStr function
ClosedPublic
Actions

Authored by Fabien on Nov 24 2020, 22:00.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC81a1f3236ee4: Consolidate service flag bit-to-name conversion to a shared serviceFlagToStr…
Summary
Side effect: this results in the RPC showing unknown service bits as
"UNKNOWN[n]" like the GUI.

Note that there is no common mask-to-vector<string> function because
both GUI and RPC would need to iterate through it to convert to their
desired target formats.

Backport of core PR18165.

Depends on D8516.

Test Plan
ninja all check-all

./src/qt/bitcoin-qt -server

Check the service bits are displayed correctly in the peers window

./src/bitcoin-cli getnetworkinfo

Check the service bits are displayed correctly

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 24 2020, 22:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 24 2020, 22:00
Fabien requested review of this revision.Nov 24 2020, 22:00
teamcity edited the summary of this revision. (Show Details)Nov 24 2020, 22:00
Harbormaster completed remote builds in B14193: Diff 26013.Nov 24 2020, 22:01
Fabien added a child revision: D8519: util: simplify the interface of serviceFlagToStr().Nov 24 2020, 22:46
Fabien added inline comments.Nov 24 2020, 22:47
src/qt/guiutil.cpp
764 ↗(On Diff #26013)

Note to reviewers: not changing check to mask here since it's a bug

deadalnix accepted this revision.Nov 25 2020, 03:36
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/protocol.cpp
272 ↗(On Diff #26013)

This service bit is decommissioned, you should remove it altogether instead of tweaking all PRs to have it.

This revision is now accepted and ready to land.Nov 25 2020, 03:36
Fabien edited the test plan for this revision. (Show Details)Nov 25 2020, 07:22
Fabien updated this revision to Diff 26025.Nov 25 2020, 08:20
Fabien edited the test plan for this revision. (Show Details)

Rebase

Harbormaster completed remote builds in B14203: Diff 26025.Nov 25 2020, 08:37
Fabien updated this revision to Diff 26031.Nov 25 2020, 16:38

Rebase

This revision was landed with ongoing or failed builds.Nov 25 2020, 16:44
Closed by commit rABC81a1f3236ee4: Consolidate service flag bit-to-name conversion to a shared serviceFlagToStr… (authored by Luke Dashjr <luke-jr+git@utopios.org>, committed by Fabien). · Explain Why
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC81a1f3236ee4: Consolidate service flag bit-to-name conversion to a shared serviceFlagToStr….
Harbormaster completed remote builds in B14208: Diff 26031.Nov 25 2020, 17:08

Revision Contents
Changeset List

PathSize
src/
5 lines
31 lines
qt/
26 lines
rpc/
23 lines

Diff 26035

View Options

src/protocol.h

Loading...
View Options

src/protocol.cpp

Loading...
View Options

src/qt/guiutil.cpp

Loading...
View Options

src/rpc/util.cpp

Loading...