Page MenuHomePhabricator
Differential D8539

use ChainstateManager to initialize chainstate
ClosedPublic
Actions

Authored by Fabien on Nov 27 2020, 15:59.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCaa2a535f9b1c: use ChainstateManager to initialize chainstate
Summary
This allows us to easily initialize multiple chainstates on startup in
future commits. It retires the g_chainstate global in lieu of
g_chainman.

Partial backport (3/5) of core PR17737:
https://github.com/bitcoin/bitcoin/pull/17737/commits/4ae29f5f0c5117032debb722d7049664fdceeae8

Includes a fix to qt/test/apptests.cpp from the next commit to unbreak
the bitcoin-qt tests:
https://github.com/bitcoin/bitcoin/pull/17737/commits/2b081c4568e8019886fdb0f2a57babc73d7487f7#diff-41e328d9ba5879d2bd026a700743339b5b300b9bee50844795ef9e27f60bdfb8R85

Depends on D8538.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 27 2020, 15:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 27 2020, 15:59
Fabien requested review of this revision.Nov 27 2020, 15:59
teamcity edited the summary of this revision. (Show Details)Nov 27 2020, 15:59
Fabien added a child revision: D8540: test: add basic tests for ChainstateManager.Nov 27 2020, 16:01
Harbormaster completed remote builds in B14228: Diff 26064.Nov 27 2020, 16:09
deadalnix accepted this revision.Nov 27 2020, 17:42
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/init.cpp
2436 ↗(On Diff #26064)

????

This revision is now accepted and ready to land.Nov 27 2020, 17:42
Fabien added inline comments.Nov 30 2020, 08:05
src/init.cpp
2436 ↗(On Diff #26064)

It's set in the catch block, so needs to be scoped accordingly. In the PR it is the same but they have 2 try/catch blocks.

Closed by commit rABCaa2a535f9b1c: use ChainstateManager to initialize chainstate (authored by James O'Beirne <james.obeirne@gmail.com>, committed by Fabien). · Explain WhyNov 30 2020, 08:06
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCaa2a535f9b1c: use ChainstateManager to initialize chainstate.

Revision Contents
Changeset List

PathSize
src/
196 lines
qt/
test/
1 line
rpc/
2 lines
test/
util/
4 lines
20 lines
61 lines

Diff 26091

View Options

src/init.cpp

Loading...
View Options

src/qt/test/apptests.cpp

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/test/util/setup_common.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...