Differential D855

Updated to allow macOS build
ClosedPublic
Actions

Authored by schancel on Dec 31 2017, 05:31.

Tags

None

Subscribers

None

Details

Reviewers

deadalnix
BMahon9

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING539160cd04ce: Updated to allow macOS build
rABC539160cd04ce: Updated to allow macOS build

Summary

The existing Bitcoin ABC code would not compile on macOS. It appears to be related to Boost. Adding "const" to a few lines in miner.h and txmempool.h allowed the build process to proceed. This change is consistent with a change performed on Bitcoin Core (https://github.com/bitcoin/bitcoin/pull/12032/files). Make boost::multi_index comparators const.

Test Plan

Confirm the changes allow the build process to proceed as desired on Linux/Windows

Diff Detail

Repository

rABC Bitcoin ABC

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1467
Build 1467: arc lint + arc unit

Event Timeline

BMahon9 created this revision.Dec 31 2017, 05:31

Owners added a reviewer: Restricted Owners Package.Dec 31 2017, 05:31

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 31 2017, 05:31

Harbormaster completed remote builds in B1467: Diff 2268.Dec 31 2017, 05:31

deadalnix accepted this revision.Jan 2 2018, 01:13

This revision is now accepted and ready to land.Jan 2 2018, 01:13

schancel commandeered this revision.Jan 2 2018, 23:06

schancel added a reviewer: BMahon9.

Closed by commit rABC539160cd04ce: Updated to allow macOS build (authored by BMahon9, committed by schancel). · Explain WhyJan 2 2018, 23:06

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

21 lines

10 lines

Diff 2268

src/miner.h

Loading...

src/txmempool.h

Loading...