Page MenuHomePhabricator
Differential D8606

[avalanche] Refactor the PeerManager
ClosedPublic
Actions

Authored by deadalnix on Dec 6 2020, 00:43.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABCfa390b74b8f0: [avalanche] Refactor the PeerManager
Summary

This keeps structure better in sync with how the code has evolved over time.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Dec 6 2020, 00:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 6 2020, 00:43
deadalnix requested review of this revision.Dec 6 2020, 00:43
Harbormaster completed remote builds in B14315: Diff 26201.Dec 6 2020, 00:56
deadalnix updated this revision to Diff 26204.Dec 6 2020, 02:14

rebase

jasonbcox accepted this revision.Dec 6 2020, 02:27
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/avalanche/peermanager.h
144 ↗(On Diff #26204)

nit: trailing /

164 ↗(On Diff #26204)

nit: This and similar comments like exposed for tests are redundant. All of them can be cleaned up to simplify things.

This revision is now accepted and ready to land.Dec 6 2020, 02:27
deadalnix updated this revision to Diff 26206.Dec 6 2020, 02:27
deadalnix removed a reviewer: jasonbcox.

Fix merge conflict in processor.cpp

This revision now requires review to proceed.Dec 6 2020, 02:27
Harbormaster completed remote builds in B14317: Diff 26204.Dec 6 2020, 02:40
Harbormaster completed remote builds in B14318: Diff 26206.Dec 6 2020, 02:53
deadalnix added a child revision: D8610: [avalanche] Only select from peers which have an actual node attached.Dec 6 2020, 16:53
deadalnix updated this revision to Diff 26247.Dec 7 2020, 16:50

Fix comments

Harbormaster completed remote builds in B14337: Diff 26247.Dec 7 2020, 17:10
jasonbcox accepted this revision.Dec 7 2020, 17:21
This revision is now accepted and ready to land.Dec 7 2020, 17:21
Closed by commit rABCfa390b74b8f0: [avalanche] Refactor the PeerManager (authored by deadalnix). · Explain WhyDec 7 2020, 17:53
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCfa390b74b8f0: [avalanche] Refactor the PeerManager.

Revision Contents
Changeset List

PathSize
src/
avalanche/
45 lines
191 lines
4 lines
test/
8 lines

Diff 26249

View Options

src/avalanche/peermanager.h

Loading...
View Options

src/avalanche/peermanager.cpp

Loading...
View Options

src/avalanche/processor.cpp

Loading...
View Options

src/avalanche/test/peermanager_tests.cpp

Loading...