Page MenuHomePhabricator

[avalanche] Refactor the PeerManager
ClosedPublic

Authored by deadalnix on Dec 6 2020, 00:43.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABCfa390b74b8f0: [avalanche] Refactor the PeerManager
Summary

This keeps structure better in sync with how the code has evolved over time.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/avalanche/peermanager.h
144 ↗(On Diff #26204)

nit: trailing /

164 ↗(On Diff #26204)

nit: This and similar comments like exposed for tests are redundant. All of them can be cleaned up to simplify things.

This revision is now accepted and ready to land.Dec 6 2020, 02:27
deadalnix removed a reviewer: jasonbcox.

Fix merge conflict in processor.cpp

This revision now requires review to proceed.Dec 6 2020, 02:27
This revision is now accepted and ready to land.Dec 7 2020, 17:21
This revision was automatically updated to reflect the committed changes.