Paths

Table of Contentst

[seeder] Use GetTime() utility function instead of accessing ctime directly
ClosedPublic
Actions

Authored by Fabien on Dec 10 2020, 02:46.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rABC1d1ea65a4a53: [seeder] Use GetTime() utility function instead of accessing ctime directly

Summary

This does two things:

Introduces mocktime for future seeder functional testing
Enforces a bit width for time, since time_t is not the same on all platforms.

Test Plan

ninja check

Run cross builds on CI

Diff Detail

Repository

rABC Bitcoin ABC

Branch

gettime

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14366
Build 28707: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang · build-clang-tidy
Build 28706: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Dec 10 2020, 02:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 10 2020, 02:46

jasonbcox requested review of this revision.Dec 10 2020, 02:46

@bot build-linux32 build-osx

teamcity awarded a token.Dec 10 2020, 02:47

Harbormaster completed remote builds in B14366: Diff 26299.Dec 10 2020, 02:57

deadalnix accepted this revision.Dec 10 2020, 03:20

This revision is now accepted and ready to land.Dec 10 2020, 03:20

Fabien commandeered this revision.Dec 10 2020, 07:58

Fabien added a reviewer: jasonbcox.

Closed by commit rABC1d1ea65a4a53: [seeder] Use GetTime() utility function instead of accessing ctime directly (authored by jasonbcox, committed by Fabien). · Explain WhyDec 10 2020, 07:59

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC1d1ea65a4a53: [seeder] Use GetTime() utility function instead of accessing ctime directly.

Revision Contents
Changeset List

Path

Size

src/

seeder/

20 lines

3 lines

10 lines

7 lines

10 lines

test/

message_writer_tests.cpp

2 lines

p2p_messaging_tests.cpp

5 lines

Diff 26299

View Options

src/seeder/bitcoin.cpp

View Options

src/seeder/db.h

View Options

src/seeder/db.cpp

View Options

src/seeder/dns.cpp

View Options

src/seeder/main.cpp

View Options

src/seeder/test/message_writer_tests.cpp

View Options

src/seeder/test/p2p_messaging_tests.cpp

[seeder] Use GetTime() utility function instead of accessing ctime directlyClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 26299

src/seeder/bitcoin.cpp

src/seeder/db.h

src/seeder/db.cpp

src/seeder/dns.cpp

src/seeder/main.cpp

src/seeder/test/message_writer_tests.cpp

src/seeder/test/p2p_messaging_tests.cpp

[seeder] Use GetTime() utility function instead of accessing ctime directly
ClosedPublic
Actions

Revision Contents
Changeset List