Page MenuHomePhabricator
Differential D8644

refactor: Pass ArgsManager into functions that register args
ClosedPublic
Actions

Authored by Fabien on Dec 10 2020, 13:15.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC318eba92a9cf: refactor: Pass ArgsManager into functions that register args
Summary
Rationale: reduce use of gArgs to decouple code and simplify future
maintenance and easier unit testing.

This PR is continuation of work started in #18926 and #18662
It covers only places that register args in ArgsManager with AddArgs()
or AddHiddenArgs().

Backport of core PR19561.

Depends on D8643.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Dec 10 2020, 13:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 10 2020, 13:15
Fabien requested review of this revision.Dec 10 2020, 13:15
teamcity edited the summary of this revision. (Show Details)Dec 10 2020, 13:15
Harbormaster completed remote builds in B14368: Diff 26302.Dec 10 2020, 13:31
Fabien added a child revision: D8646: Remove gArgs global from init.Dec 10 2020, 13:50
deadalnix requested changes to this revision.Dec 10 2020, 15:37
deadalnix added a subscriber: deadalnix.

Make sure you update the seeder too.

This revision now requires changes to proceed.Dec 10 2020, 15:37
Fabien requested review of this revision.Dec 10 2020, 16:37

The seeder is updated

deadalnix accepted this revision.Dec 11 2020, 17:29

Sorry, I missed that. Thanks, good job.

This revision is now accepted and ready to land.Dec 11 2020, 17:29
Closed by commit rABC318eba92a9cf: refactor: Pass ArgsManager into functions that register args (authored by Ivan Metlushko <metlushko@gmail.com>, committed by Fabien). · Explain WhyDec 14 2020, 07:32
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC318eba92a9cf: refactor: Pass ArgsManager into functions that register args.

Revision Contents
Changeset List

PathSize
src/
124 lines
109 lines
51 lines
4 lines
17 lines
6 lines
951 lines
qt/
59 lines
seeder/
76 lines
wallet/
135 lines
4 lines

Diff 26361

View Options

src/bitcoin-cli.cpp

Loading...
View Options

src/bitcoin-tx.cpp

Loading...
View Options

src/bitcoin-wallet.cpp

Loading...
View Options

src/chainparamsbase.h

Loading...
View Options

src/chainparamsbase.cpp

Loading...
View Options

src/dummywallet.cpp

Loading...
View Options

src/init.cpp

Loading...
View Options

src/qt/bitcoin.cpp

Loading...
View Options

src/seeder/main.cpp

Loading...
View Options

src/wallet/init.cpp

Loading...
View Options

src/walletinitinterface.h

Loading...