Differential D8655
gui: Replace interface::Node references with pointers Authored by Fabien on Dec 10 2020, 23:30. Tags None Subscribers None
Details
No change in behavior. Replacing references with pointers allows Node interface creation to be delayed until later during gui startup next commit to support implementing -ipcconnect option Partial backport (3/4) of bitcoin-core/gui PR35: Depends on D8654. ninja all check
Diff Detail
Event TimelineComment Actions Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.
Tail of the build log: [376/424] Running utility command for check-bitcoin-wallet_crypto_tests [377/424] Running utility command for check-bitcoin-timedata_tests [378/424] bitcoin: testing streams_tests [379/424] Running utility command for check-bitcoin-streams_tests [380/424] bitcoin: testing undo_tests [381/424] bitcoin: testing uint256_tests [382/424] bitcoin: testing util_threadnames_tests [383/424] Running utility command for check-bitcoin-undo_tests [384/424] Running utility command for check-bitcoin-util_threadnames_tests [385/424] Running utility command for check-bitcoin-uint256_tests [386/424] bitcoin: testing validation_chainstatemanager_tests [387/424] Running utility command for check-bitcoin-validation_chainstatemanager_tests [388/424] bitcoin: testing compilerbug_tests [389/424] bitcoin: testing checkpoints_tests [390/424] Running utility command for check-bitcoin-compilerbug_tests [391/424] bitcoin: testing validationinterface_tests [392/424] Running utility command for check-bitcoin-checkpoints_tests [393/424] bitcoin: testing txvalidationcache_tests [394/424] Running utility command for check-bitcoin-validationinterface_tests [395/424] Running utility command for check-bitcoin-txvalidationcache_tests [396/424] bitcoin: testing radix_tests [397/424] bitcoin: testing getarg_tests [398/424] Running utility command for check-bitcoin-radix_tests [399/424] bitcoin: testing ref_tests [400/424] Running utility command for check-bitcoin-getarg_tests [401/424] Running utility command for check-bitcoin-ref_tests [402/424] bitcoin: testing crypto_tests [403/424] Running utility command for check-bitcoin-crypto_tests [404/424] bitcoin: testing blockcheck_tests [405/424] Running utility command for check-bitcoin-blockcheck_tests [406/424] bitcoin: testing script_tests [407/424] bitcoin: testing validation_tests [408/424] bitcoin: testing skiplist_tests [409/424] bitcoin: testing validation_block_tests [410/424] Running utility command for check-bitcoin-script_tests [411/424] bitcoin: testing coinselector_tests FAILED: src/test/CMakeFiles/check-bitcoin-coinselector_tests cd /work/abc-ci-builds/build-clang-tidy/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang-tidy/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang-tidy/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-clang-tidy/test/log/bitcoin-coinselector_tests.log /work/abc-ci-builds/build-clang-tidy/src/test/test_bitcoin --run_test=coinselector_tests --logger=HRF,test_suite:JUNIT,message,bitcoin-coinselector_tests.xml --catch_system_errors=no Running 4 test cases... Entering test module "Bitcoin ABC unit tests" ../../src/wallet/test/coinselector_tests.cpp(22): Entering test suite "coinselector_tests" ../../src/wallet/test/coinselector_tests.cpp(149): Entering test case "bnb_search_test" ../../src/wallet/test/coinselector_tests.cpp(149): Leaving test case "bnb_search_test"; testing time: 437325us ../../src/wallet/test/coinselector_tests.cpp(355): Entering test case "knapsack_solver_test" ../../src/wallet/test/coinselector_tests.cpp(355): Leaving test case "knapsack_solver_test"; testing time: 3196572us ../../src/wallet/test/coinselector_tests.cpp(759): Entering test case "ApproximateBestSubset" Segmentation fault (core dumped) [412/424] Running utility command for check-bitcoin-validation_tests [413/424] Running utility command for check-bitcoin-skiplist_tests [414/424] Running utility command for check-bitcoin-validation_block_tests [415/424] bitcoin: testing util_tests [416/424] Running utility command for check-bitcoin-util_tests [417/424] bitcoin: testing op_reversebytes_tests [418/424] Running utility command for check-bitcoin-op_reversebytes_tests [419/424] bitcoin: testing transaction_tests [420/424] Running utility command for check-bitcoin-transaction_tests [421/424] bitcoin: testing coins_tests [422/424] Running utility command for check-bitcoin-coins_tests ninja: build stopped: cannot make progress due to previous errors. Build build-clang-tidy failed with exit code 1 |