Page MenuHomePhabricator
Differential D8667

wallet: allow transaction without change if keypool is empty
ClosedPublic
Actions

Authored by deadalnix on Dec 12 2020, 02:00.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC0fa7d0acde05: wallet: allow transaction without change if keypool is empty
Summary
  • [wallet] translate "Keypool ran out" message
  • [wallet] CreateTransaction: simplify change address check
  • [wallet] allow transaction without change if keypool is empty

This is a backport of Core PR17219

Test Plan
ninja alll check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Dec 12 2020, 02:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 12 2020, 02:00
deadalnix requested review of this revision.Dec 12 2020, 02:00
teamcity edited the summary of this revision. (Show Details)Dec 12 2020, 02:00
Harbormaster completed remote builds in B14395: Diff 26344.Dec 12 2020, 02:14
majcosta accepted this revision.Dec 12 2020, 21:27
majcosta added a subscriber: majcosta.
majcosta added inline comments.
test/functional/rpc_fundrawtransaction.py
549 ↗(On Diff #26344)

let's keep using lowerCamelCase for variables

557 ↗(On Diff #26344)

ditto

562 ↗(On Diff #26344)

ditto

This revision is now accepted and ready to land.Dec 12 2020, 21:27
Closed by commit rABC0fa7d0acde05: wallet: allow transaction without change if keypool is empty (authored by Sjors Provoost <sjors@sprovoost.nl>, committed by deadalnix). · Explain WhyDec 13 2020, 00:22
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC0fa7d0acde05: wallet: allow transaction without change if keypool is empty.
PiRK mentioned this in D9081: wallet: Fix typo in assert that is compile-time true.Jan 27 2021, 11:10
PiRK mentioned this in rABC9059575a8883: wallet: Fix typo in assert that is compile-time true.Jan 28 2021, 06:51

Revision Contents
Changeset List

PathSize
src/
wallet/
3 lines
25 lines
test/
functional/
17 lines
76 lines

Diff 26348

View Options

src/wallet/scriptpubkeyman.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

test/functional/rpc_fundrawtransaction.py

Loading...
View Options

test/functional/wallet_keypool.py

Loading...