wallet: Fix typo in assert that is compile-time true
ClosedPublic
Actions

Authored by PiRK on Jan 27 2021, 11:08.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC9059575a8883: wallet: Fix typo in assert that is compile-time true

Summary

Commit 92bcd70 (D8667] presumably added a check that a dest of type CNoDestination implies an empty scriptChange.

However, it accidentally checked for boost::variant::empty, which always returns false:

This is a backport of Core PR18853

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 27 2021, 11:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 27 2021, 11:08

PiRK requested review of this revision.Jan 27 2021, 11:08

teamcity edited the summary of this revision. (Show Details)Jan 27 2021, 11:08

PiRK edited the summary of this revision. (Show Details)Jan 27 2021, 11:10

Harbormaster completed remote builds in B15013: Diff 27357.Jan 27 2021, 11:18

majcosta accepted this revision.Jan 27 2021, 17:17

This revision is now accepted and ready to land.Jan 27 2021, 17:17

Closed by commit rABC9059575a8883: wallet: Fix typo in assert that is compile-time true (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyJan 28 2021, 06:51

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC9059575a8883: wallet: Fix typo in assert that is compile-time true.

Revision Contents
Changeset List

Path

Size

src/

test/

script_standard_tests.cpp

5 lines

wallet/

wallet.cpp

8 lines

Diff 27378

View Options

src/test/script_standard_tests.cpp